ci: forward runner arguments - #217
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1f71e776-ae8e-4de3-a48b-1330ca85d4fa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1f71e776-ae8e-4de3-a48b-1330ca85d4fa
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new mode-detection logic misclassifies short agent-eval flags (e.g., -h, -c) as modes, breaking the stated goal of forwarding options in every mode.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
script/run-benchmark.sh — Mode detection treats any first non---* token as a mode, so passing short agent-eval options… |
|
script/run-experiment.sh — Mode detection treats any first non---* token as a mode, so passing short agent-eval options… |
What changed in this PR
This PR updates the internal benchmark and experiment runner shell scripts to accept and forward additional agent-eval CLI options across all runner modes, while keeping the existing run|plan|shard|merge workflows introduced in earlier stacked PRs.
Changes:
- Relax runner argument-count checks and update usage text to document forwarding of additional
agent-evaloptions. - Add mode parsing that supports an optional explicit mode while defaulting to
run. - Forward remaining CLI arguments (
"$@") into each underlyingagent-evalinvocation.
| File | Description |
|---|---|
| script/run-benchmark.sh | Adds mode parsing and forwards remaining args to agent-eval for benchmark runs across all modes. |
| script/run-experiment.sh | Adds mode parsing and forwards remaining args to agent-eval for experiment runs across all modes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+14
to
+18
| mode="run" | ||
| if [[ $# -gt 0 && "$1" != --* ]]; then | ||
| mode="$1" | ||
| shift | ||
| fi |
Comment on lines
+14
to
+18
| mode="run" | ||
| if [[ $# -gt 0 && "$1" != --* ]]; then | ||
| mode="$1" | ||
| shift | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow up to #203.
This PR applies the runner feedback that arrived as #203 was merging and is updated for the durable plan sharding added in #204. Benchmark and experiment names remain required positional arguments, callers can optionally select
run,plan,shard, ormerge, and any remaining arguments are forwarded to the underlyingagent-evalcommand.Options can be passed directly after the name for the default
runmode or after an explicit mode. As a result, every runner mode supports options such as--log-levelwithout editing the wrapper scripts.This is a change to our internal workflow and has no public facing impact.
Changelog
New
Changed
agent-evaloptions in every execution mode.run,plan,shard, andmergebehavior now available onmain.Removed