Remove the test-specific Docker network - #938
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Network discovery is nonfunctional, removal errors are hidden, and failed tests bypass cleanup.
Review effort: Balanced
Findings: 1
Open (4)
What changed in this PR
Replaces global Docker network pruning with per-system-test network cleanup to avoid parallel-run races.
Changes:
- Adds targeted Docker network discovery and removal.
- Runs cleanup after tests and updates the changelog.
| File | Description |
|---|---|
tests/systemtests/Systemtest.py |
Implements targeted network cleanup. |
changelog-entries/820.md |
Updates the cleanup release note. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MakisH
force-pushed
the
docker-network
branch
from
September 30, 2026 16:26
9a91ec5 to
53fb155
Compare
MakisH
requested
a balanced review from Copilot
and removed request for
Copilot
September 30, 2026 16:32
MakisH
requested
a balanced review from Copilot
and removed request for
Copilot
September 30, 2026 16:34
MakisH
marked this pull request as ready for review
September 30, 2026 17:01
MakisH
force-pushed
the
docker-network
branch
from
September 30, 2026 17:04
2d9d841 to
6901a36
Compare
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Now that multiple GitHub Actions runners run on the same system, the approach of pruning Docker networks (#820) can lead to race conditions. The same applies to when running tests in parallel (#789).
This PR replaces the call to
docker network prune(before and after the test) to adocker network lsfiltered by working directory, followed by adocker network rmwith the respective id. This is executed only after the test, as cleanup.Testing in https://github.com/precice/tutorials/actions/runs/36738197148 - seems to work: networks are not accumulated.