Optimizations 1 - #3377
Draft
developit wants to merge 17 commits into
Draft
Conversation
…this` to access the associated Internal.
… of their Internals.
… components (forceUpdate, setState, FC's, hooks, etc). Anything with a reference to an Internal can call `render(callback)` on that Internal.
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Results02_replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
03_update10th1k_x16
duration
usedJSHeapSize
07_create10k
duration
usedJSHeapSize
filter_list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many_updates
duration
usedJSHeapSize
text_update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
|
|
Size Change: -334 B (1%) Total Size: 32.4 kB
ℹ️ View Unchanged
|
| "props": { | ||
| "cname": 6, | ||
| "props": { | ||
| "$flags": "f", |
Member
There was a problem hiding this comment.
I would opt to keep this to flags to encourage use of library authors for additional extensions that we don't want to support first-party
Member
Author
There was a problem hiding this comment.
I've been going back and forth on it. It pains me that this is 23b just for lags 👁
Member
There was a problem hiding this comment.
Hmm, the community being able to use this without looking at this file kind off boats well for me but yeah, one opinion 😅 also the types won't ever reflect .f unless we start doing two different type files
Member
Author
There was a problem hiding this comment.
true about types too (though that makes me think we should probably already be doing internal VS external files given we have other minified properties)
| commitRoot(commitQueue, internal); | ||
| } | ||
| } | ||
| const renderDirtyInternal = internal => { |
Member
There was a problem hiding this comment.
Let's maybe rename this to renderInternal :p
Member
Author
There was a problem hiding this comment.
renderEnqueuedInternal?
Member
There was a problem hiding this comment.
Yes something like that, it's a nit, the dirty part feels a bit odd 😅
| // re-render subscribers in response to value change | ||
| else if (props.value !== this._prev) { | ||
| this._subs.forEach(enqueueRender); | ||
| this._subs.forEach(i => i.render()); |
Member
There was a problem hiding this comment.
Suggested change
| this._subs.forEach(i => i.render()); | |
| this._subs.forEach(i => { i.render() }); |
Saves some bytes
Member
Author
There was a problem hiding this comment.
ha! can't believe I missed that.
Member
Author
There was a problem hiding this comment.
@JoviDeCroock would you believe that actually adds 3b?! gzip
Member
There was a problem hiding this comment.
Maybe it comes from the return keyword added at build time 🤷
JoviDeCroock
approved these changes
Dec 15, 2021
developit
commented
Dec 16, 2021
Thompson1985
approved these changes
Oct 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal.rerender()tointernal.render()(gzip optimizations, since "render" already appears in source)enqueueRender()into the implementation ofinternal.render()thisto access the Internal instance to be enqueued.enqueueRender()is now instead callinginternal.render(), which removes the direct dependency on that function and improves tree-shakingcreateRoot()render()andhydrate()exported functionsrerenderQueue-->renderQueue(not always repeated renders, also I type "rerender" wrong every time)process()-->processRenderQueue()createVNode()and usecreateElement()everywhere instead.flagsto.f(-23b)