Repository navigation
CI check for mudler/LocalAI#12687 (fork only, do not merge) - #1
Closed
pos-ei-don wants to merge 4 commits into
Closed
pos-ei-don wants to merge 4 commits into
pos-ei-don wants to merge 4 commits into
Conversation
The Go side already forwards the request's effort as Metadata["reasoning_effort"], but the sglang backend only read enable_thinking: every level got the same model-level thinking_budget, so low/medium/high produced identical reasoning. - New model option `effort_budgets:low=…;medium=…;high=…` picks the budget of the request's level; unlisted levels and requests without an effort keep `thinking_budget`. Parsing reuses _parse_thinking_budget. - A level listed in effort_budgets turns reasoning on for that request, so levels the Go side does not know cannot silently disable it. - ApplyReasoningEffort now treats `xhigh` and `max` as thinking levels. Before, they left DisableReasoning unset, so with a model default of "off" asking for more reasoning produced none. Signed-off-by: pos-ei-don <1822533+pos-ei-don@users.noreply.github.com>
- warn on an effort_budgets entry without a token count (high=) - update comments: enable_thinking=false still wins over a listed level - document that precedence in text-generation.md - cover xhigh/max and the empty-entry warning in the tests Signed-off-by: pos-ei-don <1822533+pos-ei-don@users.noreply.github.com>
…ad warning - ApplyReasoningEffort keeps an operator's reasoning.disable for high, xhigh and max - sglang: _configured_budget() feeds the strict-thinking warning; tested with effort_budgets alone Signed-off-by: pos-ei-don <1822533+pos-ei-don@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only CI run of the branch behind mudler#12687, with tests-apple and tests-backend-cpp removed to save minutes. Close after the run.