fix(export): resolve missing data tables in ODT export by using isset() instead of property_exists()#365
Open
bolivarf wants to merge 1 commit into
Open
Conversation
bolivarf
force-pushed
the
fix/odt-export-property-exists
branch
from
55b0a4b to
b55f5a3
Compare
Contributor
|
Please fix CI and adapt CHANGELOG. Best regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When exporting native reports to ODT format, the generated document includes the charts but the data tables are completely missing (the templates remain empty).
Cause
In
inc/common.class.php, inside thegenerateOdt()method, the code relies onproperty_exists()to check if$singledatas->datasand$multipledatas->datasare available.However, the underlying Odf library uses PHP magic methods (
__get()) to dynamically handle its segment properties. Becauseproperty_exists()evaluates only static/strict properties, it returnsfalseon these magic properties. This skips the entire loop responsible for injecting the rows into the document.Solution
Replaced
property_exists()withisset()ininc/common.class.php(lines 1294, 1300, and 1313) to properly trigger PHP's magic methods and allow the data table fields to be processed.Thank you for reviewing this contribution!