FIX / Clean plugin configuration on uninstall function#1208
Merged
Conversation
Mary-Clb
changed the title
stonebuzz
requested changes
Jun 8, 2026
| // clean configuration values | ||
| $config = new Config(); | ||
| $config->deleteByCriteria([ | ||
| 'context' => 'plugin_fields', |
Contributor
There was a problem hiding this comment.
The CI run this SQL query
SELECT COUNT(*) FROM glpi_configs WHERE context = 'plugin:{$plugin_key}'so
Suggested change
| 'context' => 'plugin_fields', | |
| 'context' => 'plugin:fields', |
Contributor
Author
|
@stonebuzz @Rom1-B can I fix rector error in the CI in this PR ? Or should I open another one |
Contributor
|
@Mary-Clb |
Rom1-B
approved these changes
Jun 9, 2026
Contributor
|
@Mary-Clb can you rebase? |
stonebuzz
approved these changes
Jun 9, 2026
Rom1-B
force-pushed
the
fix-plugin-configuration-deletion-v3
branch
from
86f6050 to
418ba64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
glpi_configsentries belonging to the plugin.