Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(release): add a static x86_64 Linux musl binary
Fixes #102
Summary
x86_64-unknown-linux-muslto the release build matrix without replacing GNU/Linux assets.Motivation
The v0.9.4 x86_64 GNU release binary requires GLIBC_2.32, GLIBC_2.33, and GLIBC_2.34, so it fails to start on a host running glibc 2.31. A locally built musl binary works on the affected machine, including interactive annotation through the unofficial OpenCode adapter.
An additional musl asset provides a download-only workaround without requiring a system glibc upgrade or a Rust/C build environment on users' machines.
Tests
scripts/smoke-musl.shaccepts a binary path and verifies:The release workflow runs this script inside both minimal Linux environments.
Local validation completed against upstream commit
f35f70ebd392198f0ab0299ecbdc9c834184c899:cargo build --release --locked -p plannotator-tui --target x86_64-unknown-linux-musl --jobs 2.debian:bullseye-slimandalpine:3.24; both passed.git diff --check.cargo fmt --all --checkpassed in Docker.cargo clippy --workspace --all-targets --locked --jobs 2 -- -D warningspassed in Docker with the musl target.The GitHub-hosted Ubuntu/musl-tools build path and the release publishing workflow have not been executed locally. Full workspace tests were not run locally for this release-configuration/docs-only patch; normal upstream CI still needs to pass.
Scope