Upgrade only MSVC to the real std::filesystem#4
Open
PhoenixBound wants to merge 1 commit into
Open
Conversation
This leaves Unix-like operating systems alone, as a more minimal alternative to the other PR I made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leaves Unix-like operating systems alone, as a more minimal alternative to #3. Despite saying it's "more minimal," I did still include the setup.py changes from that pull request, though, because those were made to allow adding MSVC-exclusive compiler flags.
I tested building it standalone and as a Python package using Visual Studio 2022, and ran the test program for the standalone build, and everything seems to work. For compiling with Python, I used the latest version of setuptools as of writing (83.0). I also made sure that the build still worked on my Debian laptop with Python 3.13.5.
This should hopefully fix the build on Visual Studio 2026, from the Python side at least. I don't have VS 2026 installed to test that directly.