GRAL-6060 document signed token caching behavior - #73
Merged
Merged
Conversation
Clarify that GET_SIGNED_TOKEN returns the previously issued token while it's still valid instead of generating a new one each call. Also pin @types/node to a version compatible with typescript@4.9, fixing a broken tsc run caused by an unpinned transitive dependency resolving to a version whose ffi.d.ts uses newer TS syntax.
dmitriyeff
added
npm-version-patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the "Get signed token" section: if the previously issued token for the extension hasn't expired yet, calling
GET_SIGNED_TOKENagain returns that same cached token instead of generating a new one.Pins
@types/nodeto^18.19.0for compatibility withtypescript@4.9.5— the unpinned transitive dependency had drifted to a version whoseffi.d.tsuses syntax the pinned TypeScript version can't parse, breakingnpm run lint:tsc.Caching was done here: https://github.com/pipedrive/marketplace-app-extensions-ui-blocks/pull/458
Test plan
npm run lintpasses (tsc --noEmit+ eslint)