Skip to content

*: add Go third-party notices - #6098

Open
dillon-zheng wants to merge 1 commit into
pingcap:masterfrom
dillon-zheng:add-third-party-notices
Open

*: add Go third-party notices#6098
dillon-zheng wants to merge 1 commit into
pingcap:masterfrom
dillon-zheng:add-third-party-notices

Conversation

@dillon-zheng

@dillon-zheng dillon-zheng commented Aug 27, 2026

Copy link
Copy Markdown

What problem does this PR solve?

Issue Number: ref #6164

What is changed and how it works?

Adds a self-contained root ThirdPartyNotices.txt for the Go dependency graph.

  • Scope: Linux/amd64 go list -deps ./..., with tests excluded.
  • Excludes the Go standard library and first-party github.com/pingcap/ and github.com/tikv/ modules.
  • Source commit: 3f0a68abf1419f9a9570e498c4a0ccff84fc2530.
  • Generator: us-docker.pkg.dev/pingcap-testing-account/internal/test/notice-generator@sha256:60fd803ae1ff5d74cc158cc9190d27c2b0bef4b892bcbe8d9b7de0c1ae2252d5 (Go 1.25.12, go-licenses v1.6.0).
  • Uses audited exact-version overrides for classifier exceptions and sourcegraph.com/sourcegraph/appdash-data; the latter embeds a pinned asset-level inventory with complete license texts and retained headers.

Check List

Tests

  • Manual test
    • Strict Go-license collector check for Linux/amd64 ./... passed.
    • Verified 346 components, self-contained license texts, no generator-local paths or raw collector URLs, and git diff --check.
  • No code

Questions

Will it cause performance regression or break compatibility?

No. This adds a documentation-only notice file.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

Signed-off-by: weizheng <wei.zheng@pingcap.com>
@ti-chi-bot

ti-chi-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • ThirdPartyNotices.txt
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 07a48c4a-c2e0-402d-82e8-d0afddfbda5a

📥 Commits

Reviewing files that changed from the base of the PR and between 3f0a68a and d58cadf.

📒 Files selected for processing (1)
  • ThirdPartyNotices.txt

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pingcap-cla-assistant

pingcap-cla-assistant Bot commented Aug 27, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 27, 2026
@dillon-zheng

Copy link
Copy Markdown
Author

/type development

@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@dillon-zheng: The label(s) type/development cannot be applied, because the repository doesn't have them.

Details

In response to this:

/type development

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@dillon-zheng

Copy link
Copy Markdown
Author

/type enhancement

@ti-chi-bot ti-chi-bot Bot added the type/enhancement The issue or PR belongs to an enhancement. label Sep 4, 2026
@dillon-zheng
dillon-zheng marked this pull request as ready for review September 4, 2026 07:33
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2026
@dillon-zheng

Copy link
Copy Markdown
Author

/run-check-issue-triage-complete

@dillon-zheng

Copy link
Copy Markdown
Author

/remove-type enhancement

@ti-chi-bot ti-chi-bot Bot removed the type/enhancement The issue or PR belongs to an enhancement. label Sep 4, 2026
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2026
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-04 07:40:05.530537542 +0000 UTC m=+1437840.701631663: ☑️ agreed by asddongmen.
  • 2026-09-04 07:40:17.087858998 +0000 UTC m=+1437852.258953108: ☑️ agreed by kennytm.

@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, kennytm, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,kennytm,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

@dillon-zheng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test d58cadf link unknown /test pull-unit-test
pull-unit-test-next-gen d58cadf link unknown /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants