Skip to content

Fix DATATIME typo and precision/scale wording - #23724

Open
yahonda wants to merge 1 commit into
pingcap:masterfrom
yahonda:fix-datatime-typo-and-precision-scale
Open

Fix DATATIME typo and precision/scale wording#23724
yahonda wants to merge 1 commit into
pingcap:masterfrom
yahonda:fix-datatime-typo-and-precision-scale

Conversation

@yahonda

@yahonda yahonda commented Sep 3, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

  • sql-mode.md: fixes a typo, DATATIMEDATETIME, in the ALLOW_INVALID_DATES mode description.
  • tidb-troubleshooting-map.md: DECIMAL(a, b) uses a for precision and b for scale; the text called both "the target precisions".

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

sql-mode.md: DATATIME was a misspelling of DATETIME.
tidb-troubleshooting-map.md: DECIMAL(a, b) uses a for precision and
b for scale, not both for precision.

Found while reviewing CodeRabbit feedback on the Japanese translation
of these two files.
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 4871505b-ad61-4401-9d40-22d4b57b68a1

📥 Commits

Reviewing files that changed from the base of the PR and between 0dc31ea and 0c3a2d8.

📒 Files selected for processing (2)
  • sql-mode.md
  • tidb-troubleshooting-map.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 3, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant