Skip to content

i18n(ja): unify Request Unit (RU) notation - #23702

Open
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-request-unit-term
Open

i18n(ja): unify Request Unit (RU) notation#23702
yahonda wants to merge 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-request-unit-term

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

"Request Unit (RU)" had two minority variant translations scattered across the corpus — 要求単位 (9 occurrences) and 要求ユニット (3 occurrences) — inconsistent with the dominant, glossary-defined term リクエストユニット (66 existing occurrences, including the glossary.md entry itself: ### リクエストユニット(RU) {#request-unit-ru}).

Unified 13 occurrences across 7 files:

  • grafana-resource-control-dashboard.md (3 sites: RRU/WRU descriptions using 要求単位 and 要求ユニット, inconsistent with the RU/WRU-per-query lines in the same list which already correctly say リクエストユニット)
  • dashboard/dashboard-resource-manager.md (2 sites)
  • releases/release-6.6.0.md, tidb-cloud/architecture-concepts.md, tidb-cloud/manage-serverless-spend-limit.md, tidb-cloud/select-cluster-tier.md (2 sites), tidb-resource-control-ru-groups.md (2 sites)

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Standardized Japanese terminology for “Request Units (RU)” across resource control, TiDB Cloud, and release documentation.
    • Updated dashboard metric names to English: “Total RU Consumed” and “RU Consumed by Resource Groups.”
    • Clarified TiFlash resource-control guidance by listing flow-control and scheduling guidance for both TiDB and TiDB Cloud variants.
    • Preserved existing metric descriptions, quota values, and reference links.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request standardizes RU terminology across Japanese and English documentation. It also adds TiFlash scheduling guidance to the TiDB Cloud platform section.

Changes

Resource control documentation

Layer / File(s) Summary
RU terminology alignment
dashboard/dashboard-resource-manager.md, grafana-resource-control-dashboard.md, releases/release-6.6.0.md, tidb-cloud/*.md
Metric labels and Japanese descriptions now use consistent RU terminology.
TiFlash platform bullet restructuring
tidb-resource-control-ru-groups.md
The TiDB Cloud platform block now includes both TiFlash flow-control and scheduling bullets.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 79b09

The terminology updates are low risk, but TiDB Cloud readers may still be sent to an insecure, English self-managed documentation link instead of the applicable Japanese Cloud page. Correct the link before merge.

Suggested reviewers: invalid-email-address, qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: unifying Japanese Request Unit (RU) terminology.
Description check ✅ Passed The description explains the terminology changes, affected files, target version, and AI involvement. The optional first-time contributor checklist is omitted, and the related-link fields are blank, b…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.)

Full details: Description check

Explanation

The description explains the terminology changes, affected files, target version, and AI involvement. The optional first-time contributor checklist is omitted, and the related-link fields are blank, but the required information is otherwise complete.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 2, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2026
@yahonda yahonda changed the title i18n(ja): unify Request Unit (RU) notation to リクエストユニット i18n(ja): unify Request Unit (RU) notation Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 2, 2026 08:15
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@yahonda
yahonda force-pushed the fix-ja-request-unit-term branch from 19fac0e to 99cefe7 Compare September 3, 2026 02:09

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 0b78118f-f638-4c2d-a94d-b92785c5f959

📥 Commits

Reviewing files that changed from the base of the PR and between 0cc9783 and 99cefe7.

📒 Files selected for processing (7)
  • dashboard/dashboard-resource-manager.md
  • grafana-resource-control-dashboard.md
  • releases/release-6.6.0.md
  • tidb-cloud/architecture-concepts.md
  • tidb-cloud/manage-serverless-spend-limit.md
  • tidb-cloud/select-cluster-tier.md
  • tidb-resource-control-ru-groups.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread tidb-resource-control-ru-groups.md
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
yahonda and others added 2 commits September 3, 2026 13:33
要求単位 and 要求ユニット were minority variant translations of
"Request Unit" scattered across 7 files (13 occurrences), inconsistent
with the corpus-dominant and glossary-defined term リクエストユニット
(66 existing occurrences, including the glossary.md entry itself).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-request-unit-term branch from 99cefe7 to 79b0953 Compare September 3, 2026 04:33
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: b28373bc-068a-4d41-afe3-af0c19f56901

📥 Commits

Reviewing files that changed from the base of the PR and between a82e814 and 79b0953.

📒 Files selected for processing (7)
  • dashboard/dashboard-resource-manager.md
  • grafana-resource-control-dashboard.md
  • releases/release-6.6.0.md
  • tidb-cloud/architecture-concepts.md
  • tidb-cloud/manage-serverless-spend-limit.md
  • tidb-cloud/select-cluster-tier.md
  • tidb-resource-control-ru-groups.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Comment thread tidb-resource-control-ru-groups.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants