Skip to content

i18n(ja): unify window function link text - #23701

Open
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-window-function-term
Open

i18n(ja): unify window function link text#23701
yahonda wants to merge 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-window-function-term

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

sql-statements/sql-statement-select.md's Window window_definition row used 機能 (feature) in its link text to functions-and-operators/window-functions.md, while both the EN source ("Window Function") and the surrounding JA prose in the same table cell correctly use 関数 (function). This was the sole occurrence of this link text with 機能 in the corpus — 28 other links to the same page already correctly say ウィンドウ関数.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated the reference link for window functions to point to the “Window Functions” documentation.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 863caa0a-0830-416b-83c4-079b0d3cb493

📥 Commits

Reviewing files that changed from the base of the PR and between a82e814 and 647e124.

📒 Files selected for processing (1)
  • sql-statements/sql-statement-select.md

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

ウィンドウ関数の詳細ページへのリンク表示名を「ウィンドウ関数」に変更しました。

Changes

ウィンドウ関数リンク

Layer / File(s) Summary
リンク表示名の更新
sql-statements/sql-statement-select.md
リンク表示名を「ウィンドウ機能」から「ウィンドウ関数」に変更しました。

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 647e1

This updates the Japanese window-functions link label for consistency without changing link behavior or product functionality. No merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the exact file and text change, gives the reason, identifies the applicable Japanese TiDB 8.5 branch, and records AI involvement. The translation and reference-link fields are…
Title check ✅ Passed The title clearly and concisely identifies the Japanese internationalization change and the link-text unification. It matches the primary change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the exact file and text change, gives the reason, identifies the applicable Japanese TiDB 8.5 branch, and records AI involvement. The translation and reference-link fields are blank, but they are not critical for this small documentation correction.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign icemap for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2026
@yahonda yahonda changed the title i18n(ja): unify window function link text to 関数 i18n(ja): unify window function link text Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 2, 2026 08:16
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@yahonda
yahonda force-pushed the fix-ja-window-function-term branch from 3465175 to 132873e Compare September 3, 2026 02:09
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 3, 2026
The link text used 機能 (feature) while both EN and the surrounding
JA prose in the same sentence correctly use 関数 (function). This was
the sole occurrence of this link text in the corpus (28 other links
to the same page already correctly say ウィンドウ関数).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-window-function-term branch from 132873e to 647e124 Compare September 3, 2026 04:32
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants