Repository navigation
i18n(ja): restore literal English SQL command headings and fix grammar in privilege-management.md - #23694
Conversation
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThe Japanese documentation updates privilege-related subsection headings to English SQL statement names, correct Japanese wording, and update resource-group link labels. Link destinations and anchors remain unchanged. No functional behavior changes are included. ChangesJapanese documentation updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🔵 Low · up to The GRANT documentation currently states the wrong required privilege, which could mislead users and cause privilege-grant attempts to fail; the bounded wording fix should receive owner attention before or with merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
62d25e6 to
6d72c60
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Team
Run ID: e5b2b657-81ad-4cda-a530-c57474dcd867
📒 Files selected for processing (2)
privilege-management.mdtidb-resource-control-ru-groups.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
6d72c60 to
fba9ff0
Compare
…r in privilege-management.md Nearly every heading in the privilege-related-operations section of privilege-management.md had translated the literal SQL command name into descriptive Japanese instead of keeping it literal English like the rest of the corpus (confirmed via TOC.md and sql-statements/sql-statement-overview.md). 31 headings restored. Also found and fixed, via close line-by-line review of the same section: - Broken verb ending (X権限ている -> X権限を持っている) - RENAME TABLE description ended as an incomplete sentence fragment and used incorrect する後 instead of した後 - Missing subject-marking は particle in several sentences - Scrambled word order (two nouns swapped) in 3 places: SHOW GRANTS (SELECT/mysql), the user-table paragraph (DELETE/user), and the tables_priv/columns_priv paragraph - ALTER USER dropped the の particle - GRANT section had a garbled structure instead of mirroring the correctly-structured REVOKE section right below it - SET RESOURCE GROUP: missing が particle - Time of effect section: missing などの before two statement-list summaries Also fixed the matching CREATE/DROP RESOURCE GROUP entries in tidb-resource-control-ru-groups.md's See also list.
fba9ff0 to
5919036
Compare
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Nearly every heading in the
privilege-related-operationssection ofprivilege-management.mdhad translated the literal SQL command name into descriptive Japanese instead of keeping it literal English like the rest of the corpus (confirmed viaTOC.mdandsql-statements/sql-statement-overview.md, which both correctly keep these as literal backtick-quoted English). 31 headings restored (ALTER, BACKUP, CREATE/DROP DATABASE, CREATE/DROP INDEX, CREATE/DROP TABLE(S), CREATE VIEW, IMPORT INTO, LOAD DATA, TRUNCATE TABLE, RENAME TABLE, ANALYZE TABLE, LOCK/UNLOCK STATS, SHOW, CREATE/DROP ROLE/USER, ALTER USER, GRANT, REVOKE, SET GLOBAL, ADMIN, SET DEFAULT ROLE, CREATE/ALTER/DROP RESOURCE GROUP, CALIBRATE RESOURCE, SET RESOURCE GROUP).Also found and fixed, via close line-by-line review of the same section:
X権限ている→X権限を持っている)RENAME TABLEdescription ended as an incomplete sentence fragment (no verb) and used incorrectする後instead ofした後はparticle in several sentences (SHOW CREATE TABLE,SHOW GRANTS×2, User+Host sentence)SHOW GRANTS(SELECT/mysql), the user-table paragraph (DELETE/user), and the tables_priv/columns_priv paragraphALTER USERdropped theのparticle, inconsistent with every sibling entryGRANTsection had a garbled single-noun-phrase structure instead of mirroring the correctly-structuredREVOKEsection right below itSET RESOURCE GROUP: missingがparticle before "ONに設定されている場合"などのbefore two statement-list summaries, making example statements read as if collectively named as one categoryAlso fixed the matching
CREATE/DROP RESOURCE GROUPentries intidb-resource-control-ru-groups.md's See also list, which had the same descriptive-Japanese mistranslation for 2 of its 3 sibling entries.(Split out from PR #23693 at the user's request, since this file's fixes are unrelated to that PR's katakana middle-dot scope.)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit