Skip to content

i18n(ja): restore literal English SQL command headings and fix grammar in privilege-management.md - #23694

Merged
qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-privilege-management-sql-headings-and-grammar
Sep 4, 2026
Merged

qiancai merged 1 commit into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-privilege-management-sql-headings-and-grammar

Conversation

@yahonda

@yahonda yahonda commented Sep 2, 2026 •

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Nearly every heading in the privilege-related-operations section of privilege-management.md had translated the literal SQL command name into descriptive Japanese instead of keeping it literal English like the rest of the corpus (confirmed via TOC.md and sql-statements/sql-statement-overview.md, which both correctly keep these as literal backtick-quoted English). 31 headings restored (ALTER, BACKUP, CREATE/DROP DATABASE, CREATE/DROP INDEX, CREATE/DROP TABLE(S), CREATE VIEW, IMPORT INTO, LOAD DATA, TRUNCATE TABLE, RENAME TABLE, ANALYZE TABLE, LOCK/UNLOCK STATS, SHOW, CREATE/DROP ROLE/USER, ALTER USER, GRANT, REVOKE, SET GLOBAL, ADMIN, SET DEFAULT ROLE, CREATE/ALTER/DROP RESOURCE GROUP, CALIBRATE RESOURCE, SET RESOURCE GROUP).

Also found and fixed, via close line-by-line review of the same section:

  • Broken verb ending (X権限ている → X権限を持っている)
  • RENAME TABLE description ended as an incomplete sentence fragment (no verb) and used incorrect する後 instead of した後
  • Missing subject-marking は particle in several sentences (SHOW CREATE TABLE, SHOW GRANTS ×2, User+Host sentence)
  • Scrambled word order (two nouns swapped) in 3 places: SHOW GRANTS (SELECT/mysql), the user-table paragraph (DELETE/user), and the tables_priv/columns_priv paragraph
  • ALTER USER dropped the の particle, inconsistent with every sibling entry
  • GRANT section had a garbled single-noun-phrase structure instead of mirroring the correctly-structured REVOKE section right below it
  • SET RESOURCE GROUP: missing が particle before "ONに設定されている場合"
  • "Time of effect" section: missing などの before two statement-list summaries, making example statements read as if collectively named as one category

Also fixed the matching CREATE/DROP RESOURCE GROUP entries in tidb-resource-control-ru-groups.md's See also list, which had the same descriptive-Japanese mistranslation for 2 of its 3 sibling entries.

(Split out from PR #23693 at the user's request, since this file's fixes are unrelated to that PR's katakana middle-dot scope.)

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated Japanese privilege-management headings to use corresponding English SQL statement names while preserving existing anchors.
    • Corrected Japanese grammar and wording in privilege, connection verification, request confirmation, and validity-period sections.
    • Updated Japanese “See also” links for resource-group SQL statements to use their English page titles.
    • No functional or behavioral changes were made.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Japanese documentation updates privilege-related subsection headings to English SQL statement names, correct Japanese wording, and update resource-group link labels. Link destinations and anchors remain unchanged. No functional behavior changes are included.

Changes

Japanese documentation updates

Layer / File(s) Summary
Privilege statement headings and wording
privilege-management.md, tidb-resource-control-ru-groups.md
Privilege subsection headings and resource-group link labels now use English SQL statement names. Japanese grammar and wording were corrected in the related sections. Destinations and anchors remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: 🔵 Low · up to 6d72c

The GRANT documentation currently states the wrong required privilege, which could mislead users and cause privilege-grant attempts to fail; the bounded wording fix should receive owner attention before or with merge.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary changes: restoring literal English SQL command headings and correcting grammar in privilege-management.md.
Description check ✅ Passed The description explains the changes, affected documentation version, AI involvement, and applicable change categories. The empty reference-link fields are non-critical.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2026
@yahonda
yahonda marked this pull request as ready for review September 2, 2026 02:16
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 2, 2026
@yahonda
yahonda force-pushed the fix-ja-privilege-management-sql-headings-and-grammar branch from 62d25e6 to 6d72c60 Compare September 2, 2026 04:22
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: e5b2b657-81ad-4cda-a530-c57474dcd867

📥 Commits

Reviewing files that changed from the base of the PR and between 23d5ab9 and 6d72c60.

📒 Files selected for processing (2)
  • privilege-management.md
  • tidb-resource-control-ru-groups.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread privilege-management.md
@yahonda
yahonda force-pushed the fix-ja-privilege-management-sql-headings-and-grammar branch from 6d72c60 to fba9ff0 Compare September 3, 2026 02:09
…r in privilege-management.md

Nearly every heading in the privilege-related-operations section of
privilege-management.md had translated the literal SQL command name
into descriptive Japanese instead of keeping it literal English like
the rest of the corpus (confirmed via TOC.md and
sql-statements/sql-statement-overview.md). 31 headings restored.

Also found and fixed, via close line-by-line review of the same
section:
- Broken verb ending (X権限ている -> X権限を持っている)
- RENAME TABLE description ended as an incomplete sentence fragment
  and used incorrect する後 instead of した後
- Missing subject-marking は particle in several sentences
- Scrambled word order (two nouns swapped) in 3 places: SHOW GRANTS
  (SELECT/mysql), the user-table paragraph (DELETE/user), and the
  tables_priv/columns_priv paragraph
- ALTER USER dropped the の particle
- GRANT section had a garbled structure instead of mirroring the
  correctly-structured REVOKE section right below it
- SET RESOURCE GROUP: missing が particle
- Time of effect section: missing などの before two statement-list
  summaries

Also fixed the matching CREATE/DROP RESOURCE GROUP entries in
tidb-resource-control-ru-groups.md's See also list.
@yahonda
yahonda force-pushed the fix-ja-privilege-management-sql-headings-and-grammar branch from fba9ff0 to 5919036 Compare September 3, 2026 04:29
@qiancai
qiancai merged commit f286290 into pingcap:i18n-ja-release-8.5 Sep 4, 2026
4 of 8 checks passed
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-04 12:16:13.900175266 +0000 UTC m=+1454409.071269380: ☑️ agreed by qiancai.

@yahonda
yahonda deleted the fix-ja-privilege-management-sql-headings-and-grammar branch September 7, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants