transaction-isolation-levels: fix wording and grammar issues - #23642
transaction-isolation-levels: fix wording and grammar issues#23642yahonda wants to merge 3 commits into
Conversation
ti-chi-bot
Bot
added
missing-translation-status
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Repeatable Read documentation clarifies statement visibility after earlier updates in the same transaction and corrects grammar in the TiDB comparison. ChangesTransaction Isolation Documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This documentation update clarifies visibility of a transaction’s own uncommitted updates and corrects grammar without changing TiDB behavior or introducing current merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description identifies the two wording and grammar fixes, explains the rationale, specifies the affected TiDB version, provides a related PR, and records AI involvement. The required information is complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yahonda
changed the title
…ement" wording "The transaction statement" reads as if it names a specific category of statement, when the intended meaning (confirmed against the Chinese source, docs-cn's "对于本事务而言，事务语句可以看到之前的语句 做出的修改") is that a statement within a transaction can see the effects of earlier statements in that SAME transaction, contrasted with not seeing other transactions' uncommitted or concurrent changes. Rewords to make the "within its own transaction" contrast explicit.
"though they sharing the same name" is not a grammatical clause (a gerund cannot follow the subject "they" as the main verb). Fixed to "though they share the same name", and added the missing article before "ANSI Repeatable Read isolation level" for consistency with its other mention later in the same paragraph. Verified against the Chinese source that the surrounding translation itself is accurate (docs-cn: "尽管名称是可重复读隔离级别，但是 TiDB 中可重复读隔离级别和 ANSI 可重复隔离级别是不同的") — only the EN grammar needed fixing, not the meaning.
288e32b to
67cb22b
Compare
[LGTM Timeline notifier]Timeline:
|
qiancai
added
translation/doing
ti-chi-bot
Bot
removed
the
missing-translation-status
Co-authored-by: Grace Cai <qqzczy@126.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
2 participants
What is changed, added or deleted? (Required)
Two EN clarity/grammar issues found while reviewing a Japanese translation of this file:
1. Ambiguous "the transaction statement" wording
The Repeatable Read section says "the transaction statement does see the effects of previous updates executed within its own transaction" — the definite noun phrase "the transaction statement" reads as if it names a specific category of statement, when the actual meaning is that a statement running within a transaction can see the effects of earlier statements in that SAME transaction (contrasted with not seeing other transactions' uncommitted or concurrently-committed changes).
Confirmed against the Chinese source (
docs-cn's corresponding sentence): "对于本事务而言，事务语句可以看到之前的语句做出的修改" — literally "as far as this [own] transaction is concerned, statements [in it] can see the modifications made by previous statements". The Chinese explicitly contrasts "本事务" (this own transaction) against the earlier-mentioned "其他事务" (other transactions); the EN translation dropped that contrast, leaving an ambiguous definite noun phrase.Reworded to make the "within its own transaction" contrast explicit:
2. Subject-verb agreement error
"though they sharing the same name" is not a grammatical clause (a gerund cannot follow the subject "they" as the main verb). Fixed to "though they share the same name", and added the missing article before "ANSI Repeatable Read isolation level" for consistency with its other mention later in the same paragraph.
Verified against the Chinese source that the surrounding translation itself is accurate (
docs-cn: "尽管名称是可重复读隔离级别，但是 TiDB 中可重复读隔离级别和 ANSI 可重复隔离级别是不同的") — only the EN grammar needed fixing, not the meaning.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit