Skip to content

test(diffs): align getPlacementBounds tests with code-box clip#985

Merged
mdo merged 1 commit into
beta-1.3from
mdo/popover-test-fix
Jul 14, 2026
Merged

test(diffs): align getPlacementBounds tests with code-box clip#985
mdo merged 1 commit into
beta-1.3from
mdo/popover-test-fix

Conversation

@mdo

@mdo mdo commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

#957 made getPlacementBounds clip popovers to [data-code]'s own box, but two Bun unit tests still asserted the old bounds and failed.

  • Update the scroll-container and window-fallback tests to stub a code box taller than the scrollport, isolating the viewport→code-relative mapping they check.
  • Add a test for the new behavior: a short file clamps the bounds to the code box.

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffs Ready Ready Preview Jul 14, 2026 10:13pm
pierre-docs-diffshub Ready Ready Preview Jul 14, 2026 10:13pm
pierre-docs-trees Ready Ready Preview Jul 14, 2026 10:13pm
pierrejs-diff-demo Ready Ready Preview Jul 14, 2026 10:13pm

Request Review

@fat fat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias

@mdo mdo merged commit 55a842a into beta-1.3 Jul 14, 2026
8 checks passed
@mdo mdo deleted the mdo/popover-test-fix branch July 14, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants