Skip to content

Fix variable type change in slice4phys for python 3.13 and an XFAIL test condition#491

Merged
RayStick merged 3 commits into
masterfrom
fix/ndarrtoint
May 29, 2026
Merged

Fix variable type change in slice4phys for python 3.13 and an XFAIL test condition#491
RayStick merged 3 commits into
masterfrom
fix/ndarrtoint

Conversation

@smoia

@smoia smoia commented May 28, 2026

Copy link
Copy Markdown
Member
  • Fix variable type change in slice4phys for python 3.13
  • Fix an old XFAIL on test_viz

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added the BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) label May 28, 2026
@github-actions github-actions Bot added the Testing This is for testing features, writing tests or producing testing code label May 28, 2026
@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.44%. Comparing base (cc37003) to head (9e7af76).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   91.15%   91.44%   +0.28%     
==========================================
  Files           8        8              
  Lines        1006     1005       -1     
==========================================
+ Hits          917      919       +2     
+ Misses         89       86       -3     
Files with missing lines Coverage Δ
phys2bids/slice4phys.py 92.10% <100.00%> (ø)
phys2bids/viz.py 98.79% <100.00%> (+3.55%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label May 28, 2026
@smoia smoia removed the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label May 29, 2026
@RayStick RayStick self-requested a review May 29, 2026 10:52

@RayStick RayStick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (in person review)

@RayStick RayStick merged commit 1756cc3 into master May 29, 2026
11 checks passed
@RayStick RayStick deleted the fix/ndarrtoint branch May 29, 2026 10:53
@RayStick

Copy link
Copy Markdown
Member

@all-contributors add @slugtmeijer for bug fix

@allcontributors

Copy link
Copy Markdown
Contributor

@RayStick

I've put up a pull request to add @slugtmeijer! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugFIX This PR generally closes a `Bug` issue, and increments the patch version (0.0.+1) Testing This is for testing features, writing tests or producing testing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants