Suppress property.nonObject and method.nonObject errors when property_exists()/method_exists() guard is present

src/Rules/Methods/MethodCallCheck.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name\FullyQualified;
+use PhpParser\Node\Scalar\String_;
 use PHPStan\Analyser\NullsafeOperatorHelper;
 use PHPStan\Analyser\Scope;
 use PHPStan\DependencyInjection\AutowiredParameter;
@@ -65,6 +66,18 @@ public function check(
 		if ($type instanceof StaticType) {
 			$typeForDescribe = $type->getStaticObjectType();
 		}
+		$methodExistsCall = new Expr\FuncCall(new FullyQualified('method_exists'), [
+			new Arg($var),
+			new Arg(new String_($methodName)),
+		]);
+		if ($scope->getType($methodExistsCall)->isTrue()->yes()) {
+			if ($type->hasMethod($methodName)->yes()) {
+				return [[], $type->getMethod($methodName, $scope)];
+			}
+
+			return [[], null];
+		}
+
 		if (!$type->canCallMethods()->yes() || $type->isClassString()->yes()) {
 			return [
 				[
@@ -122,15 +135,20 @@ public function check(
 				}
 			}
 
-			if ($astName instanceof Expr) {
+			if ($astName instanceof Identifier) {
+				$methodExistsExpr = new Expr\FuncCall(new FullyQualified('method_exists'), [
+					new Arg($var),
+					new Arg(new String_($methodName)),
+				]);
+			} else {
 				$methodExistsExpr = new Expr\FuncCall(new FullyQualified('method_exists'), [
 					new Arg($var),
 					new Arg($astName),
 				]);
+			}
 
-				if ($scope->getType($methodExistsExpr)->isTrue()->yes()) {
-					return [[], null];
-				}
+			if ($scope->getType($methodExistsExpr)->isTrue()->yes()) {
+				return [[], null];
 			}
 
 			return [

src/Rules/Properties/AccessPropertiesCheck.php

@@ -3,11 +3,11 @@
 namespace PHPStan\Rules\Properties;
 
 use PhpParser\Node\Arg;
-use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name\FullyQualified;
+use PhpParser\Node\Scalar\String_;
 use PHPStan\Analyser\NullsafeOperatorHelper;
 use PHPStan\Analyser\Scope;
 use PHPStan\DependencyInjection\AutowiredParameter;
@@ -119,6 +119,14 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
 			$typeForDescribe = $type->getStaticObjectType();
 		}
 
+		$propertyExistsCall = new FuncCall(new FullyQualified('property_exists'), [
+			new Arg($node->var),
+			new Arg(new String_($name)),
+		]);
+		if ($scope->getType($propertyExistsCall)->isTrue()->yes()) {
+			return [];
+		}
+
 		if ($type->canAccessProperties()->no() || $type->canAccessProperties()->maybe() && !$scope->isUndefinedExpressionAllowed($node)) {
 			return [
 				RuleErrorBuilder::message(sprintf(
@@ -202,15 +210,20 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
 				}
 			}
 
-			if ($node->name instanceof Expr) {
+			if ($node->name instanceof Identifier) {
+				$propertyExistsExpr = new FuncCall(new FullyQualified('property_exists'), [
+					new Arg($node->var),
+					new Arg(new String_($name)),
+				]);
+			} else {
 				$propertyExistsExpr = new FuncCall(new FullyQualified('property_exists'), [
 					new Arg($node->var),
 					new Arg($node->name),
 				]);
+			}
 
-				if ($scope->getType($propertyExistsExpr)->isTrue()->yes()) {
-					return [];
-				}
+			if ($scope->getType($propertyExistsExpr)->isTrue()->yes()) {
+				return [];
 			}
 
 			if ($hasStatic->yes()) {

src/Type/Php/MethodExistsTypeSpecifyingExtension.php

@@ -96,7 +96,7 @@ public function specifyTypes(
 			]),
 			$context,
 			$scope,
-		);
+		)->unionWith($this->createFuncCallSpec($node, $context, $scope));
 	}
 
 	private function createFuncCallSpec(FuncCall $node, TypeSpecifierContext $context, Scope $scope): SpecifiedTypes

src/Type/Php/PropertyExistsTypeSpecifyingExtension.php

@@ -89,7 +89,7 @@ public function specifyTypes(
 				]),
 				$context,
 				$scope,
-			);
+			)->unionWith($this->createFuncCallSpec($node, $context, $scope));
 		}
 
 		$propertyNode = new PropertyFetch(

tests/PHPStan/Analyser/nsrt/bug-14667.php

@@ -0,0 +1,20 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14667Nsrt;
+
+use function PHPStan\Testing\assertType;
+
+/** @param mixed $row */
+function testMixed($row): void
+{
+	if (property_exists($row, 'prop')) {
+		assertType('class-string|(object&hasProperty(prop))', $row);
+	}
+}
+
+function testExplicitMixed(mixed $row): void
+{
+	if (property_exists($row, 'prop')) {
+		assertType('class-string|(object&hasProperty(prop))', $row);
+	}
+}

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -427,10 +427,6 @@ public function testCallMethods(): void
 				'Call to an undefined method Test\Foo::lorem().',
 				911,
 			],
-			[
-				'Cannot call method foo() on class-string|object.',
-				914,
-			],
 			[
 				'Parameter #1 $callable of method Test\\MethodExists::doBar() expects callable(): mixed, array{class-string|object, \'foo\'} given.',
 				915,
@@ -4106,4 +4102,12 @@ public function testBug14596(): void
 		]);
 	}
 
+	public function testBug14667(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = true;
+		$this->checkUnionTypes = true;
+		$this->analyse([__DIR__ . '/data/bug-14667.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Methods/data/bug-14667.php

@@ -0,0 +1,41 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14667Methods;
+
+/** @param mixed $row */
+function testImplicitMixed($row): void
+{
+	if (method_exists($row, 'foo')) {
+		$row->foo();
+	}
+}
+
+function testExplicitMixed(mixed $row): void
+{
+	if (method_exists($row, 'foo')) {
+		$row->foo();
+	}
+}
+
+/** @param object|string $row */
+function testObjectOrString($row): void
+{
+	if (method_exists($row, 'foo')) {
+		$row->foo();
+	}
+}
+
+function testObject(object $row): void
+{
+	if (method_exists($row, 'bar')) {
+		$row->bar();
+	}
+}
+
+/** @param mixed $x */
+function testMixedChained($x): void
+{
+	if (method_exists($x, 'getName') && $x->getName() !== null) {
+		echo $x->getName();
+	}
+}

tests/PHPStan/Rules/Properties/AccessPropertiesInAssignRuleTest.php

@@ -258,4 +258,9 @@ public function testBug2861(): void
 		$this->analyse([__DIR__ . '/data/bug-2861-assign.php'], []);
 	}
 
+	public function testBug14667(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-14667-assign.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php

@@ -1302,4 +1302,12 @@ public function testBug2861(): void
 		$this->analyse([__DIR__ . '/data/bug-2861.php'], []);
 	}
 
+	public function testBug14667(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkUnionTypes = true;
+		$this->checkDynamicProperties = true;
+		$this->analyse([__DIR__ . '/data/bug-14667.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/bug-14667-assign.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14667Assign;
+
+/** @param mixed $row */
+function testImplicitMixed($row): void
+{
+	if (property_exists($row, 'prop')) {
+		$row->prop = 'value';
+	}
+}
+
+function testExplicitMixed(mixed $row): void
+{
+	if (property_exists($row, 'prop')) {
+		$row->prop = 'value';
+	}
+}
+
+/** @param object|string $row */
+function testObjectOrString($row): void
+{
+	if (property_exists($row, 'prop')) {
+		$row->prop = 'value';
+	}
+}

tests/PHPStan/Rules/Properties/data/bug-14667.php

@@ -0,0 +1,59 @@
+<?php declare(strict_types = 1);
+
+namespace Bug14667;
+
+/** @param mixed $row */
+function testImplicitMixed($row): void
+{
+	if (property_exists($row, 'prop')) {
+		echo $row->prop;
+	}
+}
+
+function testExplicitMixed(mixed $row): void
+{
+	if (property_exists($row, 'prop')) {
+		echo $row->prop;
+	}
+}
+
+/** @param object|string $row */
+function testObjectOrString($row): void
+{
+	if (property_exists($row, 'prop')) {
+		echo $row->prop;
+	}
+}
+
+function testObject(object $row): void
+{
+	if (property_exists($row, 'prop')) {
+		echo $row->prop;
+	}
+}
+
+final class Foo
+{
+	public function testThis(): void
+	{
+		if (property_exists($this, 'default')) {
+			echo $this->default;
+		}
+	}
+
+	/** @param self $obj */
+	public function testSelf(self $obj): void
+	{
+		if (property_exists($obj, 'default')) {
+			echo $obj->default;
+		}
+	}
+
+	/** @param mixed $x */
+	public function testMixedChained($x): void
+	{
+		if (property_exists($x, 'name') && $x->name !== null) {
+			echo $x->name;
+		}
+	}
+}