Skip to content

Avoid warning about non-nullable class-property in traits.#5479

Open
peter17 wants to merge 2 commits into
phpstan:2.2.xfrom
peter17:patch1
Open

Avoid warning about non-nullable class-property in traits.#5479
peter17 wants to merge 2 commits into
phpstan:2.2.xfrom
peter17:patch1

Conversation

@peter17
Copy link
Copy Markdown

@peter17 peter17 commented Apr 15, 2026

Fixes #14416

@phpstan-bot
Copy link
Copy Markdown
Collaborator

phpstan-bot commented Apr 15, 2026

You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x.

ondrejmirtes
ondrejmirtes requested changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are insufficient. You need to use CompositeRule and add ConstantConditionInTraitRule.

The PR that introduced ConstantConditionInTraitHelper does that in all tests for rules it changed.

Also add cases where the rule should and should not report errors. In all rule tests you touched.

Comment thread src/Rules/IssetCheck.php Outdated
@peter17
Copy link
Copy Markdown
Author

peter17 commented May 11, 2026

Hello @ondrejmirtes can you please review again? Thanks!

@peter17
Copy link
Copy Markdown
Author

peter17 commented May 22, 2026

Hello @ondrejmirtes
I find this issue quite annoying and it prevents me from upgrading to PHPStan > 2.1.44...
I don't want to ignore isset.property globally and I don't want to modify every class that use my Trait...
I can work more on this PR but I would like more precise guidance, if possible, please? I believe I made the requested changes, but I may have misunderstood.
Thanks! Regards

@peter17 peter17 requested a review from ondrejmirtes May 22, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warns too much about non-nullable class-property

3 participants

@peter17 @phpstan-bot @ondrejmirtes