Add an SVG sprite for the header's social icons - #43
Merged
Merged
Conversation
The page headers of the Symfony site, the forum and the old site draw their RSS, Facebook, X and Discord icons as inline SVG (paul999/phpbb-website-private#74). Pages are not cached by the CDN, so every page view carries the four paths again, and the same paths are copied into three repositories. Move the glyphs into images/icons/social.svg as one <symbol> per brand, so the headers can reference them with <use> and the sprite is cached like the other assets. The symbols keep the viewBoxes the inline icons used, so the rendering is unchanged, and they still fill with currentColor for the .social-icons tile styles. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #42 for paul999/phpbb-website-private#74 (WEBSITE-1433).
The header's RSS, Facebook, X and Discord icons are currently drawn as inline SVG in the page markup of all three sites. Cloudflare serves those pages as
DYNAMIC, so every page view sends the four paths again (about 1.4 KB gzipped). The same paths are also copied into three repositories.This PR adds
images/icons/social.svg, a sprite with one<symbol>per brand:social-rss,social-facebook,social-xandsocial-discord. The headers will reference it ascurrentColor, so the.social-iconstile styles from Style the header's SVG social icons as brand-coloured tiles #42 apply unchanged./assets/and all three sites are served from www.phpbb.com, which<use>requires (same origin only).?v=in the three headers needs bumping.Nothing references the sprite yet, so merging and deploying this changes nothing on its own.
Merge order
composer update phpbb/website-assetson the #74 branches of phpbb-website-private (phpbb/phpbb-website-private#240) and phpbb/website (phpbb/website#236).<use>markup to those PRs and to phpbb/phpbb3-website#109.The old site's copy of the assets serves
/assets/in production, forum included. Deploy it before or together with the header markup, or the tiles render empty.🤖 Generated with Claude Code