Shared button styles, and tidy the Support Request Template admin - #40
Merged
Merged
Conversation
For the overview in the team tools (phpbb/phpbb-website-private#226): - The move arrows are prosilver icon buttons, square and holding a chevron, in one centred row with the drag handle. - The Add buttons under the tables get room before the next heading and lose the underline the page gives its links. - The outcome and page text tables get fixed widths for their name columns. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The scoped CSS changes have no unresolved approval-blocking issues.
Pull request overview
Tidies the Support Request Template admin overview styling in css/srt.css.
Changes:
- Aligns and sizes movement controls.
- Styles action buttons and spacing.
- Sets fixed table column widths.
File summaries
| File | Description |
|---|---|
css/srt.css |
Updates scoped admin layout and control styling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
For the question form in the team tools (phpbb/phpbb-website-private#226): - js/support/srt-admin.js hides the parts marked with data-srt-types that do not apply to the chosen type, the version rules until a version list is chosen, the awaited answer until there is a condition, and the warning until an answer or an outdated release warns. A yes or no question fills blank rows with Yes and No and shows only what they do. Markdown editors that become visible are refreshed, as CodeMirror has no size while hidden. - css/srt.css: [hidden] wins over prosilver's display rules, headings for the sub-sections, and the yes or no table without its order, value and remove columns. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- css/buttons.css: the website's own buttons, taken from the team tools (phpbb-website-private's internal/team/_buttons.css.twig) so every page can use them: button1 and button2 in a .submit-buttons container, for inputs, buttons and links alike, plus submit-buttons-inline for a row inside other content and button-icon for a square icon button. It is its own file, linked from base.html.twig, so the old site's copy of the assets cannot shadow it. - css/srt.css drops its own button styles in favour of those. - js/support/srt-admin.js: the version rules follow the new phpBB version question type instead of a version list on any dropdown, and "Only ask when" offers only questions on earlier steps than the step field. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
- js/support/srt-admin.js: the empty rows offered for new answers are hidden behind the Add an answer button, which shows one per click and then adds rows from the page's template. Filling in Yes and No shows the rows it uses, and emptying them again hides them. - css/srt.css: with the script, dragging sets the answers' order, so the order numbers, which stand in for it without the script, are hidden and the column only holds the handles. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ows for Yes and No when needed Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ys, arrows only without the script Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…X, no fallbacks Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…fused move, delete through a POST override Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…s a no-op new step, reloads a kept overview, and lets its editors scroll Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39, after testing phpbb/phpbb-website-private#226 on the Docker site. It adds shared button styles for the website, reworks the Support Request Template admin, and fixes the Markdown editor's handling of required fields.
css/buttons.css(new): the website's buttonssubmit-buttons.button1is the main action andbutton2the others. Inputs, buttons and links look the same.submit-buttons-inlineputs a row next to other content, such as in a table cell.button-iconmakes a square icon button.base.html.twig, not imported throughindex.css, so the old site's copy of the assets can't shadow it.css/srt.cssbuttons.cssinstead.js/support/srt-admin.jsThe admin pages rely on this script; there are no fallbacks for browsers without JavaScript.
Question form. It only shows what applies to the question's type (
data-srt-types):On the same form:
<template>prototype. A new answer goes last.Sorting.
X-CSRF-Tokenand a JSON answer. The steps renumber straight away and a new empty step appears. If the server refuses, everything goes back and the reason is shown.Deleting. A POST with
_method=DELETEand the header token, after a confirm. Symfony routes it as DELETE; a real DELETE request is refused by the site's.htdev. Buttons show "Saving…" or "Deleting…" while they wait.js/support/srt.js(new)The generator itself. An answer that warns shows its warning right under its question as soon as it is picked, and hides it when another answer is chosen.
js/markdown-editor.jsforceSync: the textarea follows every change, so the browser checks what was typed.After merging
composer update phpbb/website-assets. Until then its pages linkbuttons.css, which the pinned assets don't have yet..htdevserves the old site's copy ofjs/markdown-editor.jsfirst, so the team tools would otherwise keep the old editor script.Checked
Against phpbb/phpbb-website-private#226 (commit
be302a48):buttons.cssinstead of their own copy.🤖 Generated with Claude Code