Drop the unused KB article attachment styles - #38
Merged
Merged
Conversation
phpbb/phpbb-website-private#21 no longer lists forum attachments on knowledge base articles: images an article needs go into the website's repository instead. The .kb-article-attachments and .kb-article-filesize rules from #36 have nothing left to style. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
Pull request overview
Removes obsolete knowledge-base article attachment CSS while preserving support-topic footer styling.
Changes:
- Deletes unused attachment and filesize rules.
- Updates the footer comment.
File summaries
| File | Description |
|---|---|
css/support_docs.css |
Removes obsolete attachment styles and retains footer link styles. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
.kb-article-attachmentsand.kb-article-filesizerules added in #36. Nothing uses them any more.phpbb/phpbb-website-private#21 no longer lists forum attachments on knowledge base articles. Images an article needs go into the website's repository instead, and the attachments section was taken out of the article page (branch
issue-21/kb-article). A search of this repo finds no other use of those classes. The footer panel, now holding only the support-topic link, keeps its styles.After this merges,
composer update phpbb/website-assetsgoes into the #21 branch.🤖 Generated with Claude Code