Disable UPX in en locale#2411
Open
andreybolonin wants to merge 4 commits into
Open
Conversation
Signed-off-by: Andrey Bolonin <andreybolonin@users.noreply.github.com>
henderkes
approved these changes
May 13, 2026
henderkes
reviewed
May 13, 2026
Co-authored-by: Marc <m@pyc.ac> Signed-off-by: Andrey Bolonin <andreybolonin@users.noreply.github.com>
henderkes
reviewed
May 13, 2026
Signed-off-by: Marc <m@pyc.ac>
henderkes
reviewed
May 13, 2026
Signed-off-by: Marc <m@pyc.ac>
henderkes
requested changes
May 13, 2026
Comment on lines
149
to
150
| On macOS, to reduce the size of the file before sending it, you can compress it. | ||
| We recommend `xz`. |
Contributor
There was a problem hiding this comment.
Is this actually still true?
Contributor
There was a problem hiding this comment.
I know, but if we're touching the subject of compression, you say it's default on on macOS, the docs say it's not, and we're touching the docs, we should fix that part too :)
I'm asking because I don't have macOS to check it quickly.
Member
|
Actually, I think we shouldn't enable UPX by default: dunglas/mercure#1182 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.