Updated possible values for display errors INI configurations#5486
Open
Narkunan wants to merge 6 commits into
Open
Updated possible values for display errors INI configurations#5486Narkunan wants to merge 6 commits into
Narkunan wants to merge 6 commits into
Conversation
lacatoire
reviewed
Apr 21, 2026
lacatoire
reviewed
Apr 21, 2026
lacatoire
reviewed
Apr 21, 2026
Contributor
Author
|
@lacatoire Updated PR please review it let me know if any changes needed |
lacatoire
reviewed
Apr 24, 2026
lacatoire
reviewed
Apr 24, 2026
lacatoire
reviewed
Apr 24, 2026
Contributor
Author
|
@lacatoire Done made all suggested changes |
lacatoire
approved these changes
Apr 24, 2026
jordikroon
reviewed
May 13, 2026
Comment on lines
+211
to
+213
| <simpara> | ||
| Possible Values: | ||
| </simpara> |
Member
There was a problem hiding this comment.
This block is redundant with the line below. Nevertheless given the structure I would remove this completely.
jordikroon
requested changes
May 13, 2026
| </note> | ||
| <simpara> | ||
| The bundled <literal>php.ini-development</literal> sets this to |
Member
There was a problem hiding this comment.
This should go above the note.
| <para> | ||
| Value <literal>"stderr"</literal> sends the errors to <literal>stderr</literal> | ||
| instead of <literal>stdout</literal>. | ||
| The accepted values are: |
Member
There was a problem hiding this comment.
Could you take inspiration from syslog.filter? In other words it is using <itemizedlist>.
<varlistentry xml:id="ini.display-errors">
<term>
<parameter>display_errors</parameter>
<type>string</type>
</term>
<listitem>
<para>
This determines whether errors should be printed to the screen
as part of the output or if they should be hidden from the user.
<itemizedlist>
<listitem>
<simpara>
<literal>Off</literal> - do not display any errors.
</simpara>
</listitem>
<listitem>
<simpara>
<literal>On</literal> or <literal>stdout</literal> - display errors to <literal>stdout</literal>. This is the default.
</simpara>
</listitem>
<listitem>
<simpara>
<literal>stderr</literal> - display errors to <literal>stderr</literal>. Only effective for the <literal>CLI,</literal><literal>phpdbg</literal>and<literal>CGI</literal> SAPIs.
</simpara>
</listitem>
</itemizedlist>
</para>
</listitem>
</varlistentry>
Member
|
Sorry this took so long to review. Overall looks good, just some structural/style comments to make it more in consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #2525