Document createFromTimestamp() for DateTime and DateTimeImmutable by mathroc · Pull Request #5103 · php/doc-en

mathroc · 2026-01-14T13:46:26Z

disclaimer: first time contributing here and edited from github web IDE. I didn't check if it's remotely close to be OK yet

Girgias

Preliminary markup review.

Co-authored-by: Gina Peter Banyard <girgias@php.net>

lacatoire · 2026-02-17T11:53:21Z

@@ -0,0 +1,71 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- $Revision$ -->
+<refentry xml:id="datetimeimmutble.createfromtimestamp" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">


Suggested change

<refentry xml:id="datetimeimmutble.createfromtimestamp" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">

<refentry xml:id="datetimeimmutable.createfromtimestamp" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">

lacatoire · 2026-02-17T11:55:47Z

+   <programlisting role="php" annotations="non-interactive">
+<![CDATA[
+<?php
+$dt = DateTime::createFromTimestamp( 1403261100 );


maybe it could be interesting to add an example with a float as a parameter ?

lacatoire · 2026-02-17T11:56:31Z

+   <programlisting role="php" annotations="non-interactive">
+<![CDATA[
+<?php
+$dt = DateTimeImmutable::createFromTimestamp( 1403261100 );


same https://github.com/php/doc-en/pull/5103/changes#r2816668016

lacatoire · 2026-02-17T11:58:34Z

+  </simpara>
+ </refsect1>
+
+ <refsect1 role="examples">


That would be great to add a section errors and seealso. The implementation throws DateRangeError for NaN or out-of-range float timestamps. Worth documenting it.

kamil-tekiela · 2026-04-21T00:37:41Z

+  &reftitle.description;
+  <methodsynopsis role="DateTime">
+   <modifier>public</modifier> <modifier>static</modifier> <type>static</type><methodname>DateTime::createFromTimestamp</methodname>
+   <methodparam><type>int|float</type><parameter>timestamp</parameter></methodparam>


Suggested change

<methodparam><type>int|float</type><parameter>timestamp</parameter></methodparam>

<methodparam><type class="union"><type>int</type><type>float</type></type><parameter>timestamp</parameter></methodparam>

kamil-tekiela · 2026-04-21T00:38:54Z

+ <refsect1 role="examples">
+  &reftitle.examples;
+  <example>
+   <title>Creating a date time object from a timestamp</title>


Suggested change

<title>Creating a date time object from a timestamp</title>

<title>Creating a <classname>DateTime</classname> object from a timestamp</title>

kamil-tekiela · 2026-04-21T00:39:11Z

+   <programlisting role="php" annotations="non-interactive">
+<![CDATA[
+<?php
+$dt = DateTime::createFromTimestamp( 1403261100 );


Suggested change

$dt = DateTime::createFromTimestamp( 1403261100 );

$dt = DateTime::createFromTimestamp(1403261100);

kamil-tekiela · 2026-04-21T00:39:49Z

+  &reftitle.description;
+  <methodsynopsis role="DateTimeImmutable">
+   <modifier>public</modifier> <modifier>static</modifier> <type>static</type><methodname>DateTimeImmutable::createFromTimestamp</methodname>
+   <methodparam><type>int|float</type><parameter>timestamp</parameter></methodparam>


Suggested change

<methodparam><type>int|float</type><parameter>timestamp</parameter></methodparam>

<methodparam><type class="union"><type>int</type><type>float</type></type><parameter>timestamp</parameter></methodparam>

kamil-tekiela · 2026-04-21T00:40:09Z

+ <refsect1 role="examples">
+  &reftitle.examples;
+  <example>
+   <title>Creating a date time object from a timestamp</title>


Suggested change

<title>Creating a date time object from a timestamp</title>

<title>Creating a <classname>DateTime</classname> object from a timestamp</title>

kamil-tekiela · 2026-04-21T00:40:21Z

+   <programlisting role="php" annotations="non-interactive">
+<![CDATA[
+<?php
+$dt = DateTimeImmutable::createFromTimestamp( 1403261100 );


Suggested change

$dt = DateTimeImmutable::createFromTimestamp( 1403261100 );

$dt = DateTimeImmutable::createFromTimestamp(1403261100);

Document createFromTimestamp(0 for DateTime and DateTimeImmutable

6d19a7d

Girgias reviewed Jan 14, 2026

View reviewed changes

Apply suggestions from code review

c8ef88d

Co-authored-by: Gina Peter Banyard <girgias@php.net>

Girgias assigned derickr Feb 6, 2026

Girgias marked this pull request as ready for review February 6, 2026 14:11

lacatoire reviewed Feb 17, 2026

View reviewed changes

kamil-tekiela requested changes Apr 21, 2026

View reviewed changes

	<refentry xml:id="datetimeimmutble.createfromtimestamp" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">
	<refentry xml:id="datetimeimmutable.createfromtimestamp" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">

	<methodparam><type>int\|float</type><parameter>timestamp</parameter></methodparam>
	<methodparam><type class="union"><type>int</type><type>float</type></type><parameter>timestamp</parameter></methodparam>

	<title>Creating a date time object from a timestamp</title>
	<title>Creating a <classname>DateTime</classname> object from a timestamp</title>

	$dt = DateTime::createFromTimestamp( 1403261100 );
	$dt = DateTime::createFromTimestamp(1403261100);

	$dt = DateTimeImmutable::createFromTimestamp( 1403261100 );
	$dt = DateTimeImmutable::createFromTimestamp(1403261100);

Uh oh!

Conversation

mathroc commented Jan 14, 2026

Uh oh!

Girgias left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants