Fixed formats and example for localized notations under compound formats - #3410
Merged
Conversation
derickr
requested changes
Jun 24, 2024
The Common Log Format row was missing the quotes around its ":"
separator, unlike every other literal on that line.
Both rows use the dd and mm symbols, which were not defined in the
"Used Symbols" table of this section; copy their definitions (and
daysuf) from the date formats table.
The hh symbol is also documented as the 12-hour clock, but every
compound format that uses it (XMLRPC, WDDX, tzcorrection) maps to the
hour24 parsing rule, as the existing "20080701T22:38:07" example
already shows. Define it accordingly.
Rules checked against ext/date/lib/parse_date.re:
clf = day "/" monthabbr "/" year4 ":" hour24lz ":" minutelz ":" secondlz space tzcorrection;
wddx = year4 "-" month "-" day "T" hour24 ":" minute ":" second;
day = (([0-2]?[0-9]) | ("3"[01])) daysuf?;
month = "0"? [0-9] | "1"[0-2];
hour24 = [01]?[0-9] | "2"[0-4];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.