fix(codecov): leave paths missing on disk out of coverage - #380
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
roxblnfk
force-pushed
the
fix/codecov-missing-files
branch
from
October 2, 2026 16:39
96f86d9 to
b7be60d
Compare
The marker list covers only the pseudo-file names known today; a path that passes the prefix filter but has no file behind it still reached the reports. `is_file()` is cached per path, misses included, so each path costs one lookup per run. Assisted-By: Claude Opus 5.5
roxblnfk
force-pushed
the
fix/codecov-missing-files
branch
from
October 2, 2026 17:12
b7be60d to
e2de780
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
eval()'d code out of coverage #379. A path that passes thesrcprefix filter but does not exist no longer reaches the reports.is_file()result is cached per path for the whole run, misses included: PHP's stat cache does not remember a failed lookup, so without it every collect would hit the filesystem again.Checklist