Align SoapHeader(s) configurator type with namespaced_element#17
Merged
veewee merged 1 commit intoJun 26, 2026
Merged
Conversation
The configurators are forwarded to veewee's namespaced_element(), whose signature is list<callable(Element): Element>. The previous callable(Node): Element annotation made strict psalm reject value() (callable(Element): Element) when passed to SoapHeader, even though it works directly on namespaced_element. Match the delegated signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Change the
$configuratorsannotation inSoapHeaderandSoapHeadersfromlist<callable(Node): Element>tolist<callable(Element): Element>.Why
Both builders forward
$configuratorsstraight into veewee'snamespaced_element(...), whose signature islist<callable(Element): Element>. The previouscallable(Node): Elementannotation diverged from the delegation target, so under strict psalm passingvalue()(which iscallable(Element): Element) toSoapHeaderwas rejected — even though the exact samevalue()works when passed directly tonamespaced_element. php-soap's own README example tripped on this.Matching the delegated signature fixes it. A short docblock note records that the
Elementsignature mirrorsnamespaced_element().Verification
vendor/bin/psalm(errorLevel 1): No errors found, 100% type inference.vendor/bin/phpunit: OK — 26 tests, 30 assertions.