Skip to content

Fix issues in inventory-metadata test #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drammock merged 2 commits into from
Sep 24, 2026
Merged

Fix issues in inventory-metadata test #415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b19098
Removed mwd ISOCODE from the ISO exceptions in test-inventory-metadata.R
varunghat Sep 24, 2026
609e317
Updated test-inventory-metadata to use mismatch_indices to fix false …
varunghat Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions tests/test-inventory-metadata.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,19 +69,6 @@ test_that("ISO codes are valid", {
# disambiguates); if glottolog is right then the ISO should
# be `laj`

"mwd", # split: http://www.iso639-3.sil.org/code/mwd
# source: https://glottolog.org/resource/reference/id/1921
# langoid: none associated with source nor current ISO code:
# https://glottolog.org/glottolog?iso=mwd
# our current glottocode `mudb1240` is associated with one half
# of the split (`dmw`). The other half `xrq` (Karranga) has no
# associated langoid:
# https://glottolog.org/glottolog?iso=xrq
# TODO: Double-check that the source really describes Mudburra
# and not Karranga. If it describes both, change nothing
# and keep this exception. If it describes only one, change
# ISO (and possibly glottocode) accordingly.

"qgu", # Extinct. https://glottolog.org/resource/languoid/id/wulg1239

"wit", # split; https://iso639-3.sil.org/request/2012-144
Expand Down Expand Up @@ -194,8 +181,7 @@ test_that("glottocodes are valid", {
mismatch_glottocodes <- phoible$Glottocode[has_glottocode][mismatch_indices]
mismatches <- unique(paste0(mismatch_ids, " (", mismatch_glottocodes, "): ", iso_from_phoible[mismatch_indices],
" - ", iso_from_glottolog[mismatch_indices]))

expect(length(mismatches) == 0,
expect(length(mismatch_indices) == 0,
paste("MISMATCHED ISO CODES BETWEEN PHOIBLE AND GLOTTOLOG (InventoryID (glottocode)): phoible - glottolog):",
paste0("- ", mismatches, collapse="\n"),
sep="\n")
Expand Down
Loading