Repository navigation
fix(heroicons): return early if file not found - #6868
Closed
kevinschweikert wants to merge 1 commit into
Closed
kevinschweikert wants to merge 1 commit into
kevinschweikert wants to merge 1 commit into
Conversation
Member
|
Can that be fixed in canonical_tailwind instead? It seems wrong to pass a class that doesn't match to a plugin that explicitly uses |
Contributor
|
Fixed upstream in tailwindlabs/tailwindcss#20052, released in 4.3.1. |
Member
|
Thanks for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a fix for aptinio/canonical_tailwind#11 i discovered that
canonical_tailwindasks the each plugin for each class if it is managed by it. So the heroicons plugin also received a request for "3px" for an arbitrary class like "p-[3px]" and the call tofs.readFileSyncerrored withpath must be a string or a file descriptor. This fix just introduces an early return when the path is not known.