Repository navigation
Use the PubSub.Sender behavior for fastlaning - #6844
Merged
Merged
Conversation
Since we want to provide people with a way to update without crashing old nodes, we still send the dispatcher and will remove it in 1.10.
SteffenDE
commented
Sep 17, 2026
SteffenDE
commented
Oct 5, 2026
josevalim
reviewed
Oct 6, 2026
Member
I'd go down this route. I assume it is a matter of merging this into v1.8 and a prunned version on main? |
Member
Author
|
It depends if we want to also bump the pubsub requirement on 1.8.X, otherwise we need some compile time checks. |
Member
|
Bumping the pubsub version should be fine, yes! It is all backwards compatible. |
SteffenDE
force-pushed
the
sd-pubsub-sender
branch
from
October 7, 2026 09:51
7045ef9 to
e94873a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to 1.9 should be done with 1.8.16 or later in between, see #6869.
Relates to phoenixframework/phoenix_pubsub#218.