Skip to content

Fix DOMElement origin drift under camera zoom #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moufmouf wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −9
Open

Fix DOMElement origin drift under camera zoom #7330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/gameobjects/domelement/DOMElementCSSRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,14 @@ var DOMElementCSSRenderer = function (renderer, src, camera, parentMatrix)
var srcMatrix = tempMatrix2;
var calcMatrix = tempMatrix3;

var dx = src.width * src.originX;
var dy = src.height * src.originY;
// Bake the (scale-aware) origin offset into the matrix and keep `transform-origin` at 0,0.
// This is what the `parentMatrix` branch already did; applying it to scene-level elements too
// keeps both paths consistent. Previously the scene-level (else) branch set
// `transform-origin: (100 * origin)%` while ALSO baking the offset into the matrix below,
// applying the origin offset twice. The two only cancel at camera zoom 1, so under camera
// zoom the element drifted by `origin * size * (1 - zoom)`.
var dx = src.width * src.originX * src.scaleX;
var dy = src.height * src.originY * src.scaleY;

var tx = '0%';
var ty = '0%';
Expand All @@ -76,13 +82,6 @@ var DOMElementCSSRenderer = function (renderer, src, camera, parentMatrix)
if (parentMatrix)
{
camMatrix.multiply(parentMatrix);
dx *= src.scaleX;
dy *= src.scaleY;
}
else
{
tx = (100 * src.originX) + '%';
ty = (100 * src.originY) + '%';
}

camMatrix.translate(-dx, -dy);
Expand Down