Whitelist showdown.win (false positive) - #1846
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughChangesWhitelist update
Merge Risk: 🟡 Moderate · up to Whitelisting showdown.win can permit wallet connections and signing flows for that domain. Confirming control of the production domain and its verification status is needed before the trust exception is merged. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Domain
showdown.winWhat it is
Showdown is a skill-based esports platform on Solana — players enter paid head-to-head duels and tournaments in CS2 and chess, with entries and prizes settled by our on-chain programs (all transactions are gasless for users via a relay). The site has been operating on mainnet since mid-August.
Why we believe this is a false positive
Phantom's in-wallet scanner has started blocking connect/sign requests on
showdown.win("This dApp could be malicious") for our users. The domain is our production app, registered and operated by us, serving standard wallet-adapter connects and Solana program transactions. We are concurrently completing Phantom Portal domain verification (DNS TXT) for the same domain.Happy to provide any additional verification your team needs — program IDs, team identity, or anything else.
Summary by CodeRabbit
showdown.winto the list of permitted website URLs.