Skip to content

Whitelist showdown.win (false positive) - #1846

Open
prexshwdwn wants to merge 1 commit into
phantom:masterfrom
prexshwdwn:whitelist-showdown-win
Open

Whitelist showdown.win (false positive)#1846
prexshwdwn wants to merge 1 commit into
phantom:masterfrom
prexshwdwn:whitelist-showdown-win

Conversation

@prexshwdwn

@prexshwdwn prexshwdwn commented Sep 3, 2026

Copy link
Copy Markdown

Domain

showdown.win

What it is

Showdown is a skill-based esports platform on Solana — players enter paid head-to-head duels and tournaments in CS2 and chess, with entries and prizes settled by our on-chain programs (all transactions are gasless for users via a relay). The site has been operating on mainnet since mid-August.

Why we believe this is a false positive

Phantom's in-wallet scanner has started blocking connect/sign requests on showdown.win ("This dApp could be malicious") for our users. The domain is our production app, registered and operated by us, serving standard wallet-adapter connects and Solana program transactions. We are concurrently completing Phantom Portal domain verification (DNS TXT) for the same domain.

Happy to provide any additional verification your team needs — program IDs, team identity, or anything else.

Summary by CodeRabbit

  • New Features
    • Added showdown.win to the list of permitted website URLs.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: d87fc7fa-9e19-4519-bc92-bd8c09027c1c

📥 Commits

Reviewing files that changed from the base of the PR and between 5030186 and 9d7d136.

📒 Files selected for processing (1)
  • whitelist.yaml

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

Changes

Whitelist update

Layer / File(s) Summary
Add whitelisted URL
whitelist.yaml
Adds showdown.win to the URL whitelist. Keeps nftplus.io unchanged.

Merge Risk: 🟡 Moderate · up to 9d7d1

Whitelisting showdown.win can permit wallet connections and signing flows for that domain. Confirming control of the production domain and its verification status is needed before the trust exception is merged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding showdown.win to the whitelist because of a reported false positive.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant