Skip to content

feat: support numeric, float and cast operands in cross-shard HAVING - #1909

Open
murex971 wants to merge 4 commits into
having-booleanfrom
having-numeric
Open

murex971 wants to merge 4 commits into
having-booleanfrom
having-numeric

Conversation

@murex971

Copy link
Copy Markdown
Contributor

No description provided.

@murex971
murex971 added this pull request to stack #1907 October 27, 2026 17:15
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.36842% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/backend/pool/connection/buffer/having.rs 97.14% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

ProjectPgDog
Branchhaving-numeric
TestbedIntel v1

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

🚨 3 Alerts

🐰 View full continuous benchmarking report in Bencher

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

ProjectPgDog
Branchhaving-numeric
TestbedIntel v1
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
cpu-per-txnBenchmark Result
Measure (units)
(Result Δ%)
Upper Boundary
Measure (units)
(Limit %)
lb-v3📈 view plot
🚷 view threshold
15.99 ops/s x 1e3
(-0.00%)Baseline: 15.99 ops/s x 1e3
15.83 ops/s x 1e3
(99.00%)
📈 view plot
🚷 view threshold
41.97 units
(+0.32%)Baseline: 41.84 units
42.26 units
(99.32%)
🐰 View full continuous benchmarking report in Bencher

@github-actions

Copy link
Copy Markdown
Contributor

Metal bench failed. 1 of 150 measures outside bounds.

suite throughput cpu/txn user cycles/txn user instr/txn kernel cycles/txn ctx/txn
pooler 28.36 (-1.2% ± 1.0%) 28,184 (-0.9% ± 1.2%) 35,220 (-0.3% ± 0.02%) 39,028 (-1.8% ± 1.7%)
lb 29.49 (-1.1% ± 1.3%) 29,659 (-0.7% ± 1.8%) 36,077 (-0.3% ± 0.03%) 40,314 (-1.8% ± 1.6%)
sharding-w2 53.31 (+1.6%) 68,056 (+1.5%) 72,438 (-0.2%) 61,337 (+1.8%) 1.41 (-0.4%)
sharding-w8 156,692 (-2.7%) 46.49 (+1.8%) 66,697 (+0.2%) 56,140 (-0.2%) 52,978 (+3.7%) 0.1491 (+5.3%), bound +3%
Counters per txn
suite frontend stall l1i refill backend stall
pooler 14,167 (-0.7% ± 2.5%) 3,225 (-0.4% ± 1.3%) 2,622 (-3.0% ± 2.0%)
lb 15,095 (-0.2% ± 3.5%) 3,322 (-0.1% ± 1.4%) 2,870 (-2.3% ± 1.5%)
sharding-w2 39,103 (+3.5%) 5,429 (+1.0%) 6,961 (-1.3%)
sharding-w8 36,943 (-1.0%) 4,979 (-0.7%) 10,002 (+7.0%)

Microbench: all 135 measures within bounds.

  • extended_cached: 15 of 15 benches faster, median -3.2% ± 0.8%
  • extended_cold: 15 of 15 benches faster, median -3.5% ± 0.3%
  • simple_cold: 15 of 15 benches faster, median -4.5% ± 0.5%
lb flamegraph vs d74cf08

lb

Open interactive for hover, zoom and search.

lb removed

Open interactive.

microbench flamegraph vs d74cf08

microbench

Open interactive for hover, zoom and search.

microbench removed

Open interactive.

pooler flamegraph vs d74cf08

pooler

Open interactive for hover, zoom and search.

pooler removed

Open interactive.

sharding-w2 flamegraph vs d74cf08

sharding-w2

Open interactive for hover, zoom and search.

sharding-w2 removed

Open interactive.

sharding-w8 flamegraph vs d74cf08

sharding-w8

Open interactive for hover, zoom and search.

sharding-w8 removed

Open interactive.

Logs

lb, microbench, pooler, sharding-w2, sharding-w8, verdict.json

Compared fad3fc2 with d74cf08.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant