Handle zero input in public bit-clearing helpers - #143
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Ones::last_positive_bit_and_unsetorIntoOnes::last_positive_bit_and_unsetwith zero panics on subtraction in debug builds, while release builds return the block width and leave zero unchanged. Use wrapping subtraction so both builds return the same result, and document the zero-input behavior.Adds regressions for both helpers covering zero, every single-bit position, and repeated removal from an all-ones block.
Validation: all-features debug and release tests, no-default-features tests, doc tests, formatting, Clippy, and a wasm32 no-default-features build. One existing allocation-abort test was excluded after reproducing its failure on the baseline; all remaining tests pass. Both new tests fail on the baseline in debug mode and pass in release mode.
Fixes #132.
Prepared with AI assistance.