Repository navigation
Conversation
This was referenced Oct 26, 2026
zibi-pplx
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. See #919 for the complete rollout groups. AI assistance: Codex implemented the scenario, documentation and this description.
zibi-pplx
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. See #961 for the complete rollout groups. AI assistance: Codex implemented the scenario, documentation and this description.
This was referenced Oct 26, 2026
zibi-pplx
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation - Preserve the native process exit-retention smoke guidance alongside the standalone Windows lifecycle scenario. This rebase changes documentation only in this PR; no live Windows test was rerun. All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the scenario, documentation and this description.
zibi-pplx
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation - Preserve the native process exit-retention smoke guidance alongside the standalone Windows lifecycle scenario. This rebase changes documentation only in this PR; no live Windows test was rerun. All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the scenario, documentation and this description.
zibi-pplx
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation - Preserve the native process exit-retention smoke guidance alongside the standalone Windows lifecycle scenario. This rebase changes documentation only in this PR; no live Windows test was rerun. All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the scenario, documentation and this description.
zibi-pplx
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation - Preserve the native process exit-retention smoke guidance alongside the standalone Windows lifecycle scenario. This rebase changes documentation only in this PR; no live Windows test was rerun. All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the scenario, documentation and this description.
zibi-pplx
added a commit
that referenced
this pull request
Oct 26, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation - Preserve the native process exit-retention smoke guidance alongside the standalone Windows lifecycle scenario. This rebase changes documentation only in this PR; no live Windows test was rerun. All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the scenario, documentation and this description.
zibi-pplx
added a commit
that referenced
this pull request
Oct 27, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation - Preserve the native process exit-retention smoke guidance alongside the standalone Windows lifecycle scenario. This rebase changes documentation only in this PR; no live Windows test was rerun. All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the scenario, documentation and this description.
zibi-pplx
added a commit
that referenced
this pull request
Oct 27, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation - Preserve the native process exit-retention smoke guidance alongside the standalone Windows lifecycle scenario. This rebase changes documentation only in this PR; no live Windows test was rerun. All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the scenario, documentation and this description.
## Summary Template registration and raw import could expand a disk before rejecting its unsupported metadata schema. Validate metadata and manifests before registration copies, import staging, cache expansion and export. Malformed documents fail instead of being normalized into legacy defaults. This is the reader prerequisite for firmware guest images. It does not enable those images: version 4 remains unsupported at this commit. Deploy this guard before producing new-schema images, and retain it as the rollback floor while those images exist. ## Validation On an isolated copy of this commit's pre-enable sources, all eight rootfs-cache tests passed. The new unsupported-schema regression fails against the previous expansion implementation, which attempts filesystem work instead of rejecting the schema. The guarded implementation leaves the disk bytes unchanged for unsupported metadata and manifests. Seventeen template import tests also passed using temporary Unix sockets. These macOS checks do not qualify Linux filesystem tools. Formatting passed. Full workspace checks remain for CI. ## Severity and risk Unsupported disk images could be modified before refusal. Existing valid Linux template handling is preserved; malformed or unsupported documents now fail earlier, including idempotent import retries. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the guard and regression coverage and drafted this description.
zibi-pplx
added a commit
that referenced
this pull request
Oct 27, 2026
## Summary Add an opt-in typed Windows scenario that creates its own sandbox, checks RDP NLA negotiation, stops and starts with the persisted contract, and deletes its resources. Poll asynchronous lifecycle state so the RPC wait budget does not truncate Windows shutdown. The fixture refuses manager restarts and device fault injection under the firmware-only opt-in. Document firmware staging, local opaque-image import, required Windows drivers and clock settings, deployment order, native SSH and fenced serial/RDP access. Evaluation disks and credentials stay outside the repository. ## Validation - Preserve the native process exit-retention smoke guidance alongside the standalone Windows lifecycle scenario. This rebase changes documentation only in this PR; no live Windows test was rerun. All 31 smoke framework tests passed. The standalone hardware run passed create, RDP negotiation, stop/start with a new execution identity, deletion and node-lease cleanup, with no cleanup failures. RDP negotiation alone is not authenticated user access; native SSH was checked separately. Agent refusal before wake is covered by the sandbox-manager guest-image tests. ## Severity and risk Severity does not apply to this explicit development test. The scenario requires an operator-supplied host and machine identity, template digest and environment reference. It cleans only its own sandbox and does not restart shared services or allocate GPUs. ## Stack Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused. AI assistance: Codex implemented the scenario, documentation and this description.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Template registration and raw import could expand a disk before rejecting its unsupported metadata schema. Validate metadata and manifests before registration copies, import staging, cache expansion and export. Malformed documents fail instead of being normalized into legacy defaults.
This is the reader prerequisite for firmware guest images. It does not enable those images: version 4 remains unsupported at this commit. Deploy this guard before producing new-schema images, and retain it as the rollback floor while those images exist.
Validation
On an isolated copy of this commit's pre-enable sources, all eight rootfs-cache tests passed. The new unsupported-schema regression fails against the previous expansion implementation, which attempts filesystem work instead of rejecting the schema. The guarded implementation leaves the disk bytes unchanged for unsupported metadata and manifests. Seventeen template import tests also passed using temporary Unix sockets. These macOS checks do not qualify Linux filesystem tools. Formatting passed. Full workspace checks remain for CI.
Severity and risk
Unsupported disk images could be modified before refusal. Existing valid Linux template handling is preserved; malformed or unsupported documents now fail earlier, including idempotent import retries.
Stack
Windows guests. #954 is a separate reader-guard deployment before #955–#959 enable opaque images. Keep that guard as the rollback floor. #955 supplies the SQLite schema before its readers/writers; deploy the matching supervisor before node/build/template/sandbox managers. Firmware guests remain opt-in, standalone and locally imported; export, pull and cross-node distribution stay refused.
AI assistance: Codex implemented the guard and regression coverage and drafted this description.
Stack created with Sapling. Best reviewed with ReviewStack.
Base: #960, the separate Cloud Hypervisor CPU execution stack.