chore: drop the general-redoc ECS redeploy from the release workflow - #332
chore: drop the general-redoc ECS redeploy from the release workflow#332dshoen619 wants to merge 1 commit into
Conversation
general-redoc is being removed, so the job that force-redeployed it on every official release has nothing left to act on. Left in place it would fail with ServiceNotFoundException once the service is gone. The job existed because that service is pinned to image_tag = "latest": the tag string never changes, so no new task definition revision is created and nothing would otherwise pull the new image. `update-service --force-new-deployment` re-ran the existing revision to force the pull. Consequence worth stating plainly: no PDP is auto-updated on release after this. general-redoc was the only one wired up; every other hosted PDP is already refreshed out of band via pdp-deployer. Two things this leaves behind, deliberately not touched here: - `permissions: id-token: write` at the top of release.yml is now dead. It was there solely for this job's OIDC auth, and no remaining job in the file assumes an AWS role. On a public repo that grants OIDC minting to the image build, which handles Docker Hub credentials and third-party actions. - The `PDP_CICD_AWS_ROLE` secret now has no consumer in this repository. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
🔍 Vulnerabilities of
|
| digest | sha256:52e38364a331b94b84edb5767ff9ff270dd685fe9aa4f437476692adbd9c9d4b |
| vulnerabilities | |
| platform | linux/amd64 |
| size | 133 MB |
| packages | 248 |
📦 Base Image python:3.13-alpine3.23
| also known as |
|
| digest | sha256:0306b86d5dbbf72135e5e0fcd630005f339b0050b2a2aa5a3946567b14fe0efe |
| vulnerabilities |
Description
Description
Description
Description
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
|
There was a problem hiding this comment.
Pull request overview
Removes the now-obsolete ECS redeploy job from the release workflow, aligning the pipeline with the removal of the general-redoc ECS service and preventing future release failures.
Changes:
- Deleted the
update-pdp-api-ecs-servicejob that assumed an AWS role and forced an ECS service redeploy after official releases.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| tags: permitio/pdp-v2:${{ github.event.release.tag_name }},permitio/pdp-v2:latest | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=max |
What
Removes the
update-pdp-api-ecs-servicejob from.github/workflows/release.yml. One file, 18 deletions, nothing else changed.Why
general-redoc is being removed, so the job has nothing left to act on. Left in place it would start failing with
ServiceNotFoundExceptionon the first official release after the service is gone.What the job did
It force-redeployed exactly one ECS service after every official (non-prerelease) release:
The flag was necessary because that service is pinned to
image_tag = "latest". The tag string never changes, so no new task definition revision is created and nothing would otherwise pull the new image —--force-new-deploymentre-runs the existing revision, which makes Fargate pull fresh.Consequence
No PDP is auto-updated on release after this. general-redoc was the only one wired into the release pipeline; every other hosted PDP is already refreshed out of band through pdp-deployer. Worth confirming that matches the intent before merging.
Left behind on purpose
Both are direct consequences of this removal, but out of scope for a PR asked to remove one job. Happy to fold either in:
permissions: id-token: write(line 8) is now dead. It existed solely for this job's OIDC auth, and no remaining job in the file assumes an AWS role. On a public repo it currently grants OIDC-minting ability tobuild-and-push-pdp, which handles Docker Hub credentials and runs third-party actions.PDP_CICD_AWS_ROLEsecret now has no consumer in this repository.deploy_sidecar.ymluses a different secret (ROLE_ARN) and is unaffected.Verification
release.ymlstill parses; remaining jobs arepdp-testsandbuild-and-push-pdp, trigger unchanged.redocmatches in the repo are ReDoc, the OpenAPI docs renderer — unrelated.origin/mainand contains this one commit.🤖 Generated with Claude Code