Repository navigation
OCTO-11628 - #439
Merged
Merged
OCTO-11628 #439
Conversation
🟢 PR Compliance ReviewRisk Level: LOW
SAFE TO MERGE - No critical issues found Full report available in workflow artifacts |
dianadersedan
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebVTTReader(time_shift_milliseconds=...)applied the shift with no lower bound. A cue shifted before 0 got a negative time, andCaption._format_timestamp()wrapped it to the end of a 24-hour clock:23:59:59.500 --> 00:00:00.500, which is invalid WebVTT because the end is before the start.23:59:59.000 --> 23:59:59.800, a stray cue at the end of the timeline.WebVTT, SRT and DFXP output wrapped the time; SAMI wrote
start="-500".Change
In
WebVTTReader._parse_timing_line, when the shift is negative:00:00:00.000and the end is kept.CaptionReadNoCaptionsis raised, as for any empty file.ignore_timing_errors=False): inverted timings are still rejected, including on dropped cues. Clamped cues no longer fail the start-ordering check; on main, any cue shifted below 0 raised.