Repository navigation
OCTO-11623 - #436
Merged
Merged
OCTO-11623 #436
Conversation
🟢 PR Compliance ReviewRisk Level: LOW
SAFE TO MERGE - No critical issues found Full report available in workflow artifacts |
OlteanuRares
changed the title
panasicov
approved these changes
Oct 2, 2026
lorandvarga
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
DFXPWriter,LegacyDFXPWriterandSAMIWriterdropping the non-breaking spaces that indent a cue's first line, which drew centred and right-justified captions flush left. They are now written as ; indentation on later lines is unchanged.Fix
DFXPReaderandSAMIReaderstripping non-breaking spaces at the start of a line along with the markup's pretty-print whitespace, so line indentation now survives a round trip.