fix: restore tour Next button (#294)#295
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294.
Problem
In the guided tours the Next button stops working from step 2 onward — it renders but does nothing. Reported for both the Start and Modeling tours.
cause
The builders
rawStep,blockStepand the result step ofactionStepalways set theonNextClickkey on the popover object — when no hook is passed, asonNextClick: undefined.An explicit
onNextClick: undefinedtherefore clobbers driver.js's built-in Next handler. The click then falls through to an unregisterednextClickevent and nothing happens.Step 1 works because
intro/floatingStepnever sets theonNextClickkey — which is exactly why the failure starts at step 2.Fix
New
prunePopover()helper inbuilder.tsthat strips keys withundefinedvalues before the popover is handed to driver.js, applied to the three affected builders.