Use a PSR-20 clock for time measurement - #58
Merged
Merged
Conversation
DefaultWorker and StopWorkerOnTimeLimitListener accept an optional ClockInterface, falling back to a new SystemClock. This makes time based behaviour testable without reflection or real sleeps. The time limit is now checked with millisecond precision, so the worker stops once the limit is reached instead of up to a second later.
DanielBadura
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultWorker and StopWorkerOnTimeLimitListener now take an optional PSR-20 ClockInterface, with a small SystemClock as default. create() accepts a clock as well and passes it on to the time limit listener. This replaces the private timeMeasure closure, so the tests no longer need reflection, and the time limit test no longer sleeps for two seconds.
The time limit listener used time() and only stopped once a full second after the limit had passed. It now compares DateTimeImmutable instances and stops as soon as the limit is reached.
psr/clock moves from a dev dependency to require. The sleep between iterations still uses usleep, since PSR-20 has no sleep method.
This touches the lines around the job call in run(), so it will conflict with #52 and #57 depending on merge order.