Accept php.ini style memory limits and reject too large values - #56
Merged
Merged
Conversation
memoryLimit now also accepts K, M and G, so values like 512M from php.ini work. Values that overflow an integer threw a TypeError or were silently capped at PHP_INT_MAX, they now throw InvalidFormat.
DanielBadura
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memoryLimit now also accepts the php.ini shorthand units K, M and G next to KB, MB and GB, so passing something like --memory-limit=512M no longer fails with InvalidFormat.
Values that don't fit into an integer were not handled either: 99999999999GB threw a TypeError from the Bytes constructor, and a huge number without unit was silently capped at PHP_INT_MAX. Both now throw InvalidFormat. The check relies on PHP returning a float when the multiplication overflows, which keeps leading zeros like 0050MB working as before.