Stop worker on SIGINT as well as SIGTERM - #55
Merged
Merged
Conversation
Pressing Ctrl+C killed the worker in the middle of a job. The new StopWorkerOnSignalListener handles SIGTERM and SIGINT by default and can be configured with other signals. create() uses it instead of StopWorkerOnSigtermSignalListener, which is now deprecated.
DanielBadura
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Ctrl+C killed the worker in the middle of a job, since only SIGTERM was handled. This adds a StopWorkerOnSignalListener that stops the worker on SIGTERM and SIGINT by default and accepts a custom list of signals. create() now uses it, and StopWorkerOnSigtermSignalListener is deprecated.
The default signals are resolved when the worker starts instead of in the constructor, because the SIG* constants don't exist without ext-pcntl and create() always instantiates the listener.
In the docs the "Graceful shutdown on SIGTERM" section is now just "Graceful shutdown", so the anchor changes from #graceful-shutdown-on-sigterm to #graceful-shutdown. README and introduction links are updated.