Allow running a stopped worker again - #54
Merged
Merged
Conversation
Calling run() a second time on a stopped worker did nothing except dispatch the started and stopped events. The flag is reset at the end of run() rather than at the start, so stop() before run() still prevents the job from running.
DanielBadura
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling run() a second time on the same worker instance did nothing except dispatch the started and stopped events, because the stop flag was never reset. It is now reset once run() has finished. Doing it at the end instead of the start keeps the existing behaviour that calling stop() before run() prevents the job from running.
This touches the same lines as #52, so whichever gets merged second needs a small rebase.