Repository navigation
Fix cache keys of the metadata factories - #220
Merged
Merged
Conversation
The PSR-6 and PSR-16 metadata factories used the class name as cache key. Class names contain a backslash, which is a reserved character in PSR-6 and PSR-16, so the factories failed with any compliant cache like symfony/cache. The class name is now hashed and prefixed, and a cache hit is only accepted if the cached metadata really belongs to the requested class. Unserialized metadata also missed some values, so metadata loaded from a cache failed as soon as they were accessed: the class name of the class metadata, and the property name, type and personal data fallback callable of the property metadata.
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DavidBadura
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PSR-6 and PSR-16 metadata factories used the class name as cache key. Class names contain a backslash, which is a reserved character in PSR-6 and PSR-16, so the factories failed with any compliant cache like symfony/cache. The class name is now hashed and prefixed, and a cache hit is only accepted if the cached metadata really belongs to the requested class.
Unserialized metadata also missed some values, so metadata loaded from a cache failed as soon as they were accessed: the class name of the class metadata, and the property name, type and personal data fallback callable of the property metadata.