Allow event tags on methods - #926
Merged
Merged
Conversation
#[EventTag] only worked on properties, so a tag that combines several values, like an account and a booking period, had to be stored as an extra property. The attribute can now be put on methods without required parameters. The return value is handled like a property value, including arrays and null.
|
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DanielBadura
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[EventTag]only worked on properties, so a tag that combines several values had to be stored as an extra property on the event. That gets annoying for patterns like closing the books, where events are tagged with their period (e.g.account-period:1/2026) and the period is derived from data the event already has.The attribute can now also be put on methods:
The return value is handled like a property value, so arrays,
null,prefixandhashwork the same way. Non-public methods are supported too. A method with required parameters or an invalid return value throws anEventTagExtractorError.