upgrade hydrator 2.0 by DavidBadura · Pull Request #777 · patchlevel/event-sourcing

DavidBadura · 2025-09-09T13:28:04Z

No description provided.

github-actions · 2025-09-09T13:34:47Z

Hello 👋

here is the most recent benchmark result:

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 3.646ms (±0.00%)   | 3.302ms (±0.00%)   | +10.41%   | 35.771mb        | 36.288mb   | -1.43%      |
| benchSave10000Events () | 514.326ms (±0.00%) | 536.299ms (±0.00%) | -4.10%    | 35.906mb        | 35.904mb   | +0.01%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.123ms (±0.00%)   | 1.152ms (±0.00%)   | -2.47%    | 35.143mb        | 35.141mb   | +0.01%      |
| benchLoad10000Events ()                | 74.973ms (±0.00%)  | 72.797ms (±0.00%)  | +2.99%    | 35.143mb        | 35.141mb   | +0.01%      |
| benchSave1Event ()                     | 1.341ms (±0.00%)   | 1.251ms (±0.00%)   | +7.21%    | 35.143mb        | 35.141mb   | +0.01%      |
| benchSave10000Events ()                | 300.185ms (±0.00%) | 300.089ms (±0.00%) | +0.03%    | 35.143mb        | 35.141mb   | +0.01%      |
| benchSave10000Aggregates ()            | 9.005s (±0.00%)    | 8.838s (±0.00%)    | +1.90%    | 35.143mb        | 35.141mb   | +0.01%      |
| benchSave10000AggregatesTransaction () | 5.658s (±0.00%)    | 5.698s (±0.00%)    | -0.71%    | 35.143mb        | 35.141mb   | +0.01%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                     | memory                                     |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 107.373ms (±0.00%) | 107.575ms (±0.00%) | -0.19%    | 35.723mb        | 35.720mb   | +0.01%      |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

NoopSubscriptionEngineBench
===========================

+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                     | memory                                     |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 105.390ms (±0.00%) | 103.049ms (±0.00%) | +2.27%    | 48.298mb        | 48.296mb   | +0.00%      |
+---------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.541s (±0.00%) | 3.570s (±0.00%) | -0.81%    | 48.298mb        | 48.296mb   | +0.00%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                 | memory                                     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>   | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 3.150ms (±0.00%) | 3.146ms (±0.00%) | +0.13%    | 5.080mb         | 4.881mb    | +4.08%      |
| benchUpdate () | 4.320ms (±0.00%) | 4.445ms (±0.00%) | -2.81%    | 5.124mb         | 5.067mb    | +1.12%      |
| benchBoth ()   | 7.130ms (±0.00%) | 6.957ms (±0.00%) | +2.48%    | 5.756mb         | 5.072mb    | +13.47%     |
+----------------+------------------+------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>   | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.250ms (±0.00%) | 1.220ms (±0.00%)   | +2.49%    | 36.593mb        | 35.805mb   | +2.20%      |
| benchLoad10000Events ()                | 2.624s (±0.00%)  | 112.311ms (±0.00%) | +2236.51% | 36.593mb        | 35.805mb   | +2.20%      |
| benchSave1Event ()                     | 1.904ms (±0.00%) | 2.235ms (±0.00%)   | -14.79%   | 36.593mb        | 35.805mb   | +2.20%      |
| benchSave10000Events ()                | 2.883s (±0.00%)  | 325.256ms (±0.00%) | +786.31%  | 36.593mb        | 35.807mb   | +2.20%      |
| benchSave10000Aggregates ()            | 13.972s (±0.00%) | 13.607s (±0.00%)   | +2.68%    | 36.593mb        | 35.805mb   | +2.20%      |
| benchSave10000AggregatesTransaction () | 10.618s (±0.00%) | 10.288s (±0.00%)   | +3.21%    | 36.593mb        | 36.045mb   | +1.52%      |
+----------------------------------------+------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                   | memory                                     |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 72.569ms (±0.00%) | 73.969ms (±0.00%) | -1.89%    | 35.214mb        | 35.146mb   | +0.19%      |
| benchLoad10000Events ()                | 1.202ms (±0.00%)  | 1.416ms (±0.00%)  | -15.12%   | 35.214mb        | 35.145mb   | +0.19%      |
+----------------------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupTaggableStoreBench
=============================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.250ms (±0.00%)   | 1.236ms (±0.00%)   | +1.07%    | 36.309mb        | 36.306mb   | +0.01%      |
| benchLoad10000Events ()                | 74.284ms (±0.00%)  | 79.219ms (±0.00%)  | -6.23%    | 36.309mb        | 36.306mb   | +0.01%      |
| benchSave1Event ()                     | 1.237ms (±0.00%)   | 1.269ms (±0.00%)   | -2.52%    | 36.309mb        | 36.306mb   | +0.01%      |
| benchSave10000Events ()                | 319.748ms (±0.00%) | 328.670ms (±0.00%) | -2.71%    | 36.309mb        | 36.306mb   | +0.01%      |
| benchSave10000Aggregates ()            | 8.901s (±0.00%)    | 8.997s (±0.00%)    | -1.06%    | 36.309mb        | 36.307mb   | +0.01%      |
| benchSave10000AggregatesTransaction () | 5.730s (±0.00%)    | 5.752s (±0.00%)    | -0.37%    | 36.309mb        | 36.307mb   | +0.01%      |
| benchAppend1Event ()                   | 1.544ms (±0.00%)   | 1.683ms (±0.00%)   | -8.27%    | 36.309mb        | 36.306mb   | +0.01%      |
| benchAppend100Events ()                | 7.738ms (±0.00%)   | 7.989ms (±0.00%)   | -3.14%    | 36.309mb        | 36.306mb   | +0.01%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

DanielBadura · 2025-09-19T10:13:10Z

This could also land in 3.x, no?

DanielBadura · 2026-02-15T14:07:13Z

Ok, now this cannot land anymore in 3.x

DavidBadura · 2026-02-15T16:07:46Z

I would first look at what the optimal version for 4.x would look like and then see if it can be implemented in 3.x.

DanielBadura · 2026-06-19T11:23:43Z

 #[Processor('delete_personal_data')]
-final class DeletePersonalDataProcessor
+final class DeleteSensitiveDataProcessor


should be consistent

DanielBadura · 2026-06-19T11:33:27Z

+
+Renaming an event through an upcaster is no longer supported, because the event class is
+already resolved from the stored event name before the payload is upcasted.
+Use [event aliases](events.md#alias) instead.


Renaming an event through an upcaster is no longer supported,

This phrasing is better suited in the upgrade docs. Here in the actual 4.x docs, we should not say that its is no longer supported. Instead we should hint the user how he could solve it and link to the right direction. So I think a note how to get rid of old event names form the store should be added, if we keep this section here: recreate the store (which even does not need any translator)

DanielBadura · 2026-06-19T11:37:05Z

+
+:::danger
+The key table layout changed (`crypto_keys` -> `cryptography_keys` with new columns).
+Existing keys must be migrated, otherwise stored sensitive data can no longer be decrypted.


We should add a note how to migrate

DavidBadura · 2026-09-23T14:29:00Z

Superseded by #900, which does the hydrator 2.0 upgrade on top of the current 4.0.x. The relevant parts from here were taken over: the event name and class are passed as context to the hydrator, the headers serializer factories accept a custom hydrator, the upgrade guide covers the moved cryptography attributes, and the personal data page was renamed to sensitive data. The DefaultSnapshotStore constructor change was left out since it is unrelated to the hydrator upgrade.

DanielBadura reviewed Sep 11, 2025

View reviewed changes

Comment thread docs/pages/index.md Outdated

Comment thread docs/pages/normalizer.md Outdated

Comment thread docs/pages/snapshots.md Outdated

DavidBadura force-pushed the upgrade-hydrator-2.0 branch from da48f2e to 3ad383c Compare November 16, 2025 20:00

DavidBadura force-pushed the upgrade-hydrator-2.0 branch 3 times, most recently from c8bf73c to 432a747 Compare November 28, 2025 20:46

DavidBadura force-pushed the upgrade-hydrator-2.0 branch 5 times, most recently from 2b345c4 to b82ed3c Compare February 13, 2026 14:25

DavidBadura added this to the 4.0.0 milestone Feb 16, 2026

DavidBadura marked this pull request as draft February 23, 2026 09:59

DavidBadura force-pushed the upgrade-hydrator-2.0 branch 2 times, most recently from 73842e6 to d3ce7a5 Compare February 24, 2026 14:43

DavidBadura self-assigned this Mar 24, 2026

DavidBadura mentioned this pull request Jun 13, 2026

docs: complete 4.0 upgrade guide for merged breaking changes #861

Merged

DavidBadura force-pushed the upgrade-hydrator-2.0 branch 3 times, most recently from 9a1ead6 to 8c81f2b Compare June 17, 2026 08:06

update

ece40e4

DavidBadura force-pushed the upgrade-hydrator-2.0 branch from 8c81f2b to ece40e4 Compare June 17, 2026 08:12

DavidBadura marked this pull request as ready for review June 17, 2026 18:56

DavidBadura requested a review from DanielBadura June 17, 2026 18:56

DanielBadura reviewed Jun 19, 2026

View reviewed changes

DanielBadura mentioned this pull request Jun 30, 2026

Support Upcasting of Headers (or Messages) #815

Open

DanielBadura linked an issue Jun 30, 2026 that may be closed by this pull request

Support Upcasting of Headers (or Messages) #815

Open

DavidBadura closed this Sep 23, 2026

Navigation Menu

Repository navigation

upgrade hydrator 2.0 - #777

upgrade hydrator 2.0#777
DavidBadura wants to merge 1 commit into
4.0.xfrom
upgrade-hydrator-2.0

DavidBadura commented Sep 9, 2025

Uh oh!

github-actions Bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielBadura commented Sep 19, 2025

Uh oh!

DanielBadura commented Feb 15, 2026

Uh oh!

DavidBadura commented Feb 15, 2026

Uh oh!

DanielBadura Jun 19, 2026

Uh oh!

DanielBadura Jun 19, 2026

Uh oh!

DanielBadura Jun 19, 2026

Uh oh!

DavidBadura commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

DavidBadura commented Sep 9, 2025

Uh oh!

github-actions Bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielBadura commented Sep 19, 2025

Uh oh!

DanielBadura commented Feb 15, 2026

Uh oh!

DavidBadura commented Feb 15, 2026

Uh oh!

DanielBadura Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

DanielBadura Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

DanielBadura Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

DavidBadura commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Sep 9, 2025 •

edited

Loading