bugfix: schema updation issue#1686
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughTwo methods in ChangesSchema File Detection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/parseable/streams.rs`:
- Around line 532-533: The filter method on line 532 and the similar filter on
line 542 use Path::ends_with(".schema") which checks path-component suffixes
instead of actual filename suffixes, causing it to incorrectly skip schema files
with names like `.ingestor.{id}.schema`. Replace the Path::ends_with check with
a proper filename string comparison by extracting the file name using
file_name() and converting it to a string, then checking if it
ends_with(".schema") to correctly match both plain .schema files and ingestor
schema files. Apply this fix to both filter operations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d515a5a1-240d-49a1-88bd-21d114a3defd
📒 Files selected for processing (1)
src/parseable/streams.rs
in standalone mode, the `.schema` file from staging wasn't getting pushed to storage due to the improper usage of `path().extension()` function. It was always returning `None`. Instead of checking whether the extension is `schema`, check if the file path ends with `.schema`
fa2c4bd to
f44f167
Compare
in standalone mode, the
.schemafile from staging wasn't getting pushed to storage due to the improper usage ofpath().extension()function. It was always returningNone. Instead of checking whether the extension isschema, check if the file path ends with.schemaFixes #XXXX.
Description
This PR has:
Summary by CodeRabbit
.schema) rather than relying on exact extension matching, resulting in more reliable schema loading.