docs: Document retry behavior and how to tune it - #599
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Warning Review limit reached
Next review available in: 21 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue
No issue. The adapter's behavior on throttled and failed requests is currently undocumented, so an operator hitting
503 SlowDownhas no indication that anything is configurable.Approach
Adds a
Retry Behaviorsection covering what the adapter actually does, which is to configure nothing and inherit the AWS SDK defaults, and where the knobs are.Everything stated was measured against a server returning
503 SlowDownrather than taken from the SDK docs:Content:
500,502,503,504, and transient network errors. After the attempts are exhausted the error reaches Parse Server, which reports a genericFILE_SAVE_ERROR, so the real cause is only in the server log.HeadBucket, cached on the instance afterwards. A throttled response there fails the upload before any object data is sent, and it is logged without an error code, because aHEADresponse carries no body for the SDK to parse one from. Both are worth knowing when reading logs from a throttled deployment.s3overridesto the client, verified formaxAttemptsandretryMode.maxAttemptsmakes it worse, since every client retries at the same pace.retryMode: "adaptive"is the relevant setting because it rate limits outgoing requests rather than just retrying them. Points at the AWS guidance on prefixes and request rates.Documentation only. No behavior change, no source touched.