Skip to content

chore: cache space reservation when sorting is enabled - #480

Open
dkharms wants to merge 1 commit into
mainfrom
0-cache-size-calc
Open

chore: cache space reservation when sorting is enabled#480
dkharms wants to merge 1 commit into
mainfrom
0-cache-size-calc

Conversation

@dkharms

@dkharms dkharms commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

Previous version substracted cache size even if we skip documents sorting.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.17%. Comparing base (8cf7b08) to head (69e2c47).

Files with missing lines Patch % Lines
fracmanager/config.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   71.16%   71.17%           
=======================================
  Files         232      232           
  Lines       18466    18467    +1     
=======================================
+ Hits        13142    13143    +1     
+ Misses       4341     4340    -1     
- Partials      983      984    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Block_Unpack-4 8cf7b0 ae8a2c
91216.00 ns/op 101760.00 ns/op 1.12 🔴
ProcessDocuments-4 8cf7b0 ae8a2c
508.00 B/op 13673.00 B/op 26.92 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants